Project

General

Profile

Actions
Copy link

User story #10142

closed

Extend variable_dict_from_file to allow reading yaml and csv files

Added by Alexis Mousset almost 8 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Generic methods
Target version:
5.0.13
Pull Request:
https://github.com/Normation/ncf/pull...
UX impact:
Suggestion strength:
Require - I need this to use Rudder as I intend
User visibility:
Effort required:
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

By using readdata() (which appeared in 3.7), we can autodetect data type and create a compatible method with autodection of the type (with a fallback on JSON), and also a more generic method with a parameter for the type (for example when the file does not have a correct extension).

We could keep the current implementation for 3.6.

Related issues 2 (0 open — 2 closed)

Related to Rudder - User story #10586: Compile Rudder agent with YAML supportRejectedActions
Related to Rudder - Bug #15657: Document that variable_dict_from_file_type#csv needs CRLFReleasedBenoît PECCATTEActions
Actions
Copy link
 #1

Updated by Alexis Mousset almost 8 years ago

  • Target version set to master
Actions
Copy link
 #2

Updated by Alexis Mousset almost 8 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis Mousset
Actions
Copy link
 #3

Updated by Alexis Mousset almost 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/525
Actions
Copy link
 #4

Updated by Alexis Mousset over 7 years ago

Actions
Copy link
 #5

Updated by Benoît PECCATTE over 7 years ago

  • Assignee changed from Benoît PECCATTE to Alexis Mousset
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from master to 4.2.2
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.2 to 4.2.3
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.2.3 to 4.2.4
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.2.4 to 4.2.5
Actions
Copy link
 #10

Updated by Alexis Mousset over 6 years ago

  • Status changed from Pending technical review to New
  • Target version changed from 4.2.5 to 4.3.0~rc2
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.0~rc2 to 4.3.0~rc3
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.0~rc3 to 4.3.0
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.0 to 4.3.1
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.1 to 4.3.2
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.2 to 410
Actions
Copy link
 #16

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 410 to 4.3.2
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.2 to 4.3.3
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.3.3 to 4.3.4
Actions
Copy link
 #19

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 4.3.4 to 4.3.5
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.3.5 to 4.3.6
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.3.6 to 4.3.7
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.3.7 to 4.3.8
Actions
Copy link
 #23

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.3.8 to 4.3.9
Actions
Copy link
 #24

Updated by Alexis Mousset almost 6 years ago

  • Target version changed from 4.3.9 to 4.3.10
Actions
Copy link
 #25

Updated by François ARMAND over 5 years ago

  • Target version changed from 4.3.10 to 4.3.11
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.3.11 to 4.3.12
Actions
Copy link
 #27

Updated by Benoît PECCATTE over 5 years ago

  • Target version changed from 4.3.12 to 6.0.0~beta1
Actions
Copy link
 #28

Updated by Alexis Mousset over 5 years ago

  • Status changed from New to In progress

I'm taking over this issue!

Actions
Copy link
 #29

Updated by Alexis Mousset over 5 years ago

  • Target version changed from 6.0.0~beta1 to 5.0.13
Actions
Copy link
 #30

Updated by Alexis Mousset over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Benoît PECCATTE
Actions
Copy link
 #31

Updated by Alexis Mousset over 5 years ago

  • Pull Request changed from https://github.com/Normation/ncf/pull/525 to https://github.com/Normation/ncf/pull/998
Actions
Copy link
 #35

Updated by Vincent MEMBRÉ over 5 years ago

  • Suggestion strength set to Require - I need this to use Rudder as I intend
Actions
Copy link
 #36

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from Benoît PECCATTE to Alexis Mousset
Actions
Copy link
 #37

Updated by Anonymous over 5 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:c333abec006f61055e1e6e6bd9f8c5bc015ce4d5.

Actions
Copy link
 #38

Updated by Alexis Mousset over 5 years ago

Applied in changeset commit:4ab31c9aceaa4be8b69b92db35bb48e0278152f1.

Actions
Copy link
 #39

Updated by Vincent MEMBRÉ about 5 years ago

  • Fix check set to To do
Actions
Copy link
 #40

Updated by Vincent MEMBRÉ about 5 years ago

  • Name check set to To do
Actions
Copy link
 #41

Updated by François ARMAND about 5 years ago

  • Related to Bug #15657: Document that variable_dict_from_file_type#csv needs CRLF added
Actions
Copy link
 #42

Updated by François ARMAND about 5 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #43

Updated by Alexis Mousset about 5 years ago

  • Name check changed from To do to Reviewed
Actions
Copy link
 #44

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.13 which was released today.

Actions
Copy link
 #45

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link

Also available in: Atom PDF