Project

General

Profile

User story #10142

Extend variable_dict_from_file to allow reading yaml and csv files

Added by Alexis MOUSSET almost 3 years ago. Updated 2 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Suggestion strength:
Require - I need this to use Rudder as I intend
User visibility:
Effort required:

Description

By using readdata() (which appeared in 3.7), we can autodetect data type and create a compatible method with autodection of the type (with a fallback on JSON), and also a more generic method with a parameter for the type (for example when the file does not have a correct extension).

We could keep the current implementation for 3.6.


Related issues

Related to Rudder - User story #10586: Compile Rudder agent with YAML supportRejectedActions
Related to Rudder - Bug #15657: Document that variable_dict_from_file_type#csv needs CRLFPending releaseActions

Associated revisions

Revision c333abec (diff)
Added by Alexis Mousset 5 months ago

Fixes #10142: Extend variable_dict_from_file to allow reading yaml and csv files

Revision 4ab31c9a (diff)
Added by Alexis MOUSSET 5 months ago

Fixes #10142: Extend variable_dict_from_file to allow reading yaml and csv files

History

#1

Updated by Alexis MOUSSET almost 3 years ago

  • Target version set to master
#2

Updated by Alexis MOUSSET almost 3 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET
#3

Updated by Alexis MOUSSET almost 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/525
#4

Updated by Alexis MOUSSET over 2 years ago

#5

Updated by Benoît PECCATTE over 2 years ago

  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
#6

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from master to 4.2.2
#7

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 4.2.2 to 4.2.3
#8

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 4.2.3 to 4.2.4
#9

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 4.2.4 to 4.2.5
#10

Updated by Alexis MOUSSET over 1 year ago

  • Status changed from Pending technical review to New
  • Target version changed from 4.2.5 to 4.3.0~rc2
#11

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.0~rc2 to 4.3.0~rc3
#12

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.0~rc3 to 4.3.0
#13

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.0 to 4.3.1
#14

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.1 to 4.3.2
#15

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.2 to 410
#16

Updated by Benoît PECCATTE over 1 year ago

  • Target version changed from 410 to 4.3.2
#17

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.2 to 4.3.3
#18

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.3.3 to 4.3.4
#19

Updated by Benoît PECCATTE over 1 year ago

  • Target version changed from 4.3.4 to 4.3.5
#20

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 4.3.5 to 4.3.6
#21

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 4.3.6 to 4.3.7
#22

Updated by Vincent MEMBRÉ 12 months ago

  • Target version changed from 4.3.7 to 4.3.8
#23

Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 4.3.8 to 4.3.9
#24

Updated by Alexis MOUSSET 10 months ago

  • Target version changed from 4.3.9 to 4.3.10
#25

Updated by François ARMAND 9 months ago

  • Target version changed from 4.3.10 to 4.3.11
#26

Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 4.3.11 to 4.3.12
#27

Updated by Benoît PECCATTE 7 months ago

  • Target version changed from 4.3.12 to 6.0.0~beta1
#28

Updated by Alexis MOUSSET 5 months ago

  • Status changed from New to In progress

I'm taking over this issue!

#29

Updated by Alexis MOUSSET 5 months ago

  • Target version changed from 6.0.0~beta1 to 5.0.13
#30

Updated by Alexis MOUSSET 5 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE
#31

Updated by Alexis MOUSSET 5 months ago

  • Pull Request changed from https://github.com/Normation/ncf/pull/525 to https://github.com/Normation/ncf/pull/998
#35

Updated by Vincent MEMBRÉ 5 months ago

  • Suggestion strength set to Require - I need this to use Rudder as I intend
#36

Updated by Rudder Quality Assistant 5 months ago

  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
#37

Updated by Anonymous 5 months ago

  • Status changed from Pending technical review to Pending release
#41

Updated by François ARMAND 3 months ago

  • Related to Bug #15657: Document that variable_dict_from_file_type#csv needs CRLF added
#44

Updated by Vincent MEMBRÉ 2 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.13 which was released today.

Also available in: Atom PDF