Project

General

Profile

Actions

User story #10142

closed

Extend variable_dict_from_file to allow reading yaml and csv files

Added by Alexis MOUSSET over 4 years ago. Updated over 1 year ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Suggestion strength:
Require - I need this to use Rudder as I intend
User visibility:
Effort required:

Description

By using readdata() (which appeared in 3.7), we can autodetect data type and create a compatible method with autodection of the type (with a fallback on JSON), and also a more generic method with a parameter for the type (for example when the file does not have a correct extension).

We could keep the current implementation for 3.6.


Related issues

Related to Rudder - User story #10586: Compile Rudder agent with YAML supportRejectedActions
Related to Rudder - Bug #15657: Document that variable_dict_from_file_type#csv needs CRLFReleasedBenoît PECCATTEActions
Actions #1

Updated by Alexis MOUSSET over 4 years ago

  • Target version set to master
Actions #2

Updated by Alexis MOUSSET over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET
Actions #3

Updated by Alexis MOUSSET over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/525
Actions #4

Updated by Alexis MOUSSET about 4 years ago

Actions #5

Updated by Benoît PECCATTE almost 4 years ago

  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
Actions #6

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from master to 4.2.2
Actions #7

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 4.2.2 to 4.2.3
Actions #8

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 4.2.3 to 4.2.4
Actions #9

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.2.4 to 4.2.5
Actions #10

Updated by Alexis MOUSSET about 3 years ago

  • Status changed from Pending technical review to New
  • Target version changed from 4.2.5 to 4.3.0~rc2
Actions #11

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.3.0~rc2 to 4.3.0~rc3
Actions #12

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.3.0~rc3 to 4.3.0
Actions #13

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.3.0 to 4.3.1
Actions #14

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.3.1 to 4.3.2
Actions #15

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 4.3.2 to 410
Actions #16

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 410 to 4.3.2
Actions #17

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 4.3.2 to 4.3.3
Actions #18

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 4.3.3 to 4.3.4
Actions #19

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 4.3.4 to 4.3.5
Actions #20

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.3.5 to 4.3.6
Actions #21

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.3.6 to 4.3.7
Actions #22

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.3.7 to 4.3.8
Actions #23

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.3.8 to 4.3.9
Actions #24

Updated by Alexis MOUSSET over 2 years ago

  • Target version changed from 4.3.9 to 4.3.10
Actions #25

Updated by François ARMAND about 2 years ago

  • Target version changed from 4.3.10 to 4.3.11
Actions #26

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 4.3.11 to 4.3.12
Actions #27

Updated by Benoît PECCATTE about 2 years ago

  • Target version changed from 4.3.12 to 6.0.0~beta1
Actions #28

Updated by Alexis MOUSSET almost 2 years ago

  • Status changed from New to In progress

I'm taking over this issue!

Actions #29

Updated by Alexis MOUSSET almost 2 years ago

  • Target version changed from 6.0.0~beta1 to 5.0.13
Actions #30

Updated by Alexis MOUSSET almost 2 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE
Actions #31

Updated by Alexis MOUSSET almost 2 years ago

  • Pull Request changed from https://github.com/Normation/ncf/pull/525 to https://github.com/Normation/ncf/pull/998
Actions #35

Updated by Vincent MEMBRÉ almost 2 years ago

  • Suggestion strength set to Require - I need this to use Rudder as I intend
Actions #36

Updated by Rudder Quality Assistant almost 2 years ago

  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
Actions #37

Updated by Anonymous almost 2 years ago

  • Status changed from Pending technical review to Pending release
Actions #41

Updated by François ARMAND over 1 year ago

  • Related to Bug #15657: Document that variable_dict_from_file_type#csv needs CRLF added
Actions #44

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.13 which was released today.

Actions

Also available in: Atom PDF