Bug #10216: "id" setting is silently ignored for new group created through the REST API. - Rudder - Issue Tracker

Actions

Copy link

Bug #10216

closed

"id" setting is silently ignored for new group created through the REST API.

Added by Dmitry Svyatogorov almost 8 years ago. Updated over 2 years ago.

Status:

Released

Priority:

N/A

Assignee:

Vincent MEMBRÉ

Category:

API

Target version:

5.0.19

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Major - prevents use of part of Rudder | no simple workaround

UX impact:

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Small

Priority:

100

Name check:

Fix check:

Checked

Regression:

Description

According to https://www.rudder-project.org/rudder-api-doc/#api-Groups-createGroup
new group can be created with the exact "id". But as for Rudder 4.0.2, "id" setting is silently ignored and new UUID is generated.
For example try to PUT the following json:

{
  "id": "9a92538b-d01f-4157-9fff-ed1d1a8d3443",
  "category": "GroupRoot",
  "enabled": true,
  "displayName": "###TEST#",
  "query": {
    "select": "node",
    "composition": "And",
    "where": [
      {
        "objectType": "node",
        "attribute": "nodeHostname",
        "comparator": "regex",
        "value": ".*\\.xxx\\.tld" 
      }
    ]
  }
}

The answer looks like

{"action": "createGroup","id": "2ef61fa0-426d-40a1-99c1-c1f62b4d5664","result": "success"…

Then check the "id" in answer body / WEB-UI against the requested value.

This seriously complicates group & rule transmitting between 2 nodes through REST-API because of need in translation dictionary.

Actions

Copy link

Updated by Vincent MEMBRÉ almost 8 years ago

Assignee set to Vincent MEMBRÉ
Target version set to 3.1.18

Thus bug was fixed on Directive on a recent version, but we did not took time to look in other versions

Actions

Copy link

Updated by Dmitry Svyatogorov almost 8 years ago

Sorry, Vincent. What version is "recent"? "Latest release: 4.0.2" is affected (I found the problem affects at least Groups and Rules PUT API).
Upcoming 4.0.3? It's really important for me as it can significantly reduce my current task.

Actions

Copy link

Updated by Vincent MEMBRÉ almost 8 years ago

Target version changed from 3.1.18 to 3.1.19

Actions

Copy link

Updated by Benoît PECCATTE over 7 years ago

Found in version (s) 4.0.2 added

Actions

Copy link

Updated by Benoît PECCATTE over 7 years ago

Found in version(s) old deleted (~~4.0.2~~)

Actions

Copy link

Updated by François ARMAND over 7 years ago

Severity set to Major - prevents use of part of Rudder | no simple workaround
User visibility set to Operational - other Techniques | Technique editor | Rudder settings

Actions

Copy link

Updated by Benoît PECCATTE over 7 years ago

Priority set to 36

Actions

Copy link

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.19 to 3.1.20

Actions

Copy link

Updated by Jonathan CLARKE over 7 years ago

Assignee deleted (~~Vincent MEMBRÉ~~)
Priority changed from 36 to 35

Actions

Copy link

#10

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.20 to 3.1.21

Actions

Copy link

#11

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.21 to 3.1.22
Priority changed from 35 to 34

Actions

Copy link

#12

Updated by Benoît PECCATTE over 7 years ago

Priority changed from 34 to 49

Actions

Copy link

#13

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.22 to 3.1.23
Priority changed from 49 to 48

Actions

Copy link

#14

Updated by Dmitry Svyatogorov over 7 years ago

As for current Rudder 4.1.5, uuid is ignored in creation of all objects except of directives (and parameters, as they are passed by name).

Those techniques which are constructed from NCF are in fact out-of-API. The workaround is to transfer ncf tree to new server, then save each technique through web-ui.
After that, ncf becomes available in directives.

https://github.com/ds-voix/VX-PBX/blob/master/RUDDER/rudder-replica.py (Rudder-Rudder replication with inheritance model) was updated to last version.
It contains a number of workarounds against current API bugs.

Actions

Copy link

#15

Updated by Vincent MEMBRÉ about 7 years ago

Target version changed from 3.1.23 to 3.1.24
Priority changed from 48 to 47

Actions

Copy link

#16

Updated by Vincent MEMBRÉ about 7 years ago

Target version changed from 3.1.24 to 3.1.25
Priority changed from 47 to 46

Actions

Copy link

#17

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 3.1.25 to 387
Priority changed from 46 to 45

Actions

Copy link

#18

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 387 to 4.1.10
Priority changed from 45 to 44

Actions

Copy link

#19

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 4.1.10 to 4.1.11
Priority changed from 44 to 43

Actions

Copy link

#20

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.11 to 4.1.12

Actions

Copy link

#21

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.12 to 4.1.13

Actions

Copy link

#22

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.13 to 4.1.14

Actions

Copy link

#23

Updated by Benoît PECCATTE over 6 years ago

Target version changed from 4.1.14 to 4.1.15

Actions

Copy link

#24

Updated by Vincent MEMBRÉ about 6 years ago

Target version changed from 4.1.15 to 4.1.16

Actions

Copy link

#25

Updated by Vincent MEMBRÉ about 6 years ago

Target version changed from 4.1.16 to 4.1.17

Actions

Copy link

#26

Updated by François ARMAND about 6 years ago

Priority changed from 43 to 0

it's still the case in 4.3.7.

Actions

Copy link

#27

Updated by Vincent MEMBRÉ almost 6 years ago

Target version changed from 4.1.17 to 4.1.18

Actions

Copy link

#28

Updated by Vincent MEMBRÉ almost 6 years ago

Target version changed from 4.1.18 to 4.1.19

Actions

Copy link

#29

Updated by Alexis Mousset almost 6 years ago

Target version changed from 4.1.19 to 4.1.20

Actions

Copy link

#30

Updated by François ARMAND over 5 years ago

Target version changed from 4.1.20 to 4.1.21

Actions

Copy link

#31

Updated by Vincent MEMBRÉ over 5 years ago

Target version changed from 4.1.21 to 4.1.22

Actions

Copy link

#32

Updated by Vincent MEMBRÉ over 5 years ago

Target version changed from 4.1.22 to 4.1.23

Actions

Copy link

#33

Updated by Vincent MEMBRÉ over 5 years ago

Target version changed from 4.1.23 to 4.1.24

Actions

Copy link

#34

Updated by Vincent MEMBRÉ over 5 years ago

Target version changed from 4.1.24 to 588

Actions

Copy link

#35

Updated by François ARMAND over 5 years ago

Target version changed from 588 to 5.0.13
User visibility changed from Operational - other Techniques | Technique editor | Rudder settings to Operational - other Techniques | Rudder settings | Plugins
Effort required set to Small
Priority changed from 0 to 56

We need to accept creation of object with a predefined ID, else we won't be able to synchronise things between rudder instances by API.
We need to check that the ID is not already present and fail on that case.

Actions

Copy link

#36