Project

General

Profile

Bug #10304

Broken variable expression when using node properties in the technique editor

Added by Avit Sidis about 2 years ago. Updated about 1 year ago.

Status:
Released
Priority:
N/A
Category:
Web - Technique editor
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Small
Priority:
56

Description

Whenever we use a node property in the technique editor inside a method like command, result classes contain a broken variable expression. Once we execute generated directive we encounter this error message:
error: Broken variable expression, index brackets do not balance, in 'node.properties[ENV_'


Related issues

Related to ncf - Bug #8586: Wrong definition of class condition if we use a variable with [ ] in itRejectedActions
Related to ncf - Bug #11600: Result class containing {} are not properly canonizedReleasedActions

Associated revisions

Revision 4ec79bb6 (diff)
Added by Benoît PECCATTE over 1 year ago

Fixes #10304: Broken variable expression when using node properties in the technique editor

History

#1

Updated by Benoît PECCATTE about 2 years ago

  • Category set to Web - Technique editor
#2

Updated by François ARMAND about 2 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
#3

Updated by Benoît PECCATTE about 2 years ago

  • Priority set to 36
#4

Updated by Nicolas CHARLES about 2 years ago

  • Effort required set to Small
  • Priority changed from 36 to 44

effort seems quite small, it's only the regex

regex = re.compile("[^\$\{\}a-zA-Z0-9_](?![^{}]+})|\$(?!{)")

in tools/ncf_rudder.py to change

someone competend in regex could fix it pretty easily

#5

Updated by Nicolas CHARLES about 2 years ago

  • Related to Bug #8586: Wrong definition of class condition if we use a variable with [ ] in it added
#6

Updated by Benoît PECCATTE almost 2 years ago

  • Priority changed from 44 to 53
#7

Updated by Nicolas CHARLES over 1 year ago

  • Related to Bug #11600: Result class containing {} are not properly canonized added
#8

Updated by Benoît PECCATTE over 1 year ago

  • Priority changed from 53 to 60
#9

Updated by Benoît PECCATTE over 1 year ago

  • Target version set to 4.1.10
  • Priority changed from 60 to 57
#10

Updated by Benoît PECCATTE over 1 year ago

  • Status changed from New to In progress
  • Assignee set to Benoît PECCATTE
#11

Updated by Benoît PECCATTE over 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ncf/pull/696
#12

Updated by Rudder Quality Assistant over 1 year ago

  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
#13

Updated by Benoît PECCATTE over 1 year ago

  • Status changed from Pending technical review to Pending release
#14

Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from Pending release to Released
  • Priority changed from 57 to 56

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Also available in: Atom PDF