Actions
User story #10368
closed
Add expires on static content ncf builder
Pull Request:
UX impact:
Suggestion strength:
Advise - This would make Rudder significantly better | easier | simpler
User visibility:
Effort required:
Medium
Name check:
Fix check:
Regression:
Description
Add expires on static content of the builder.
Updated by Alexis Mousset over 7 years ago
- Status changed from New to In progress
- Assignee set to Alexis Mousset
Updated by Alexis Mousset over 7 years ago
- Project changed from 41 to Rudder
- Category changed from Packaging to Packaging
- Status changed from In progress to New
- Target version changed from 1.0 to 4.1.0
Updated by Alexis Mousset over 7 years ago
- Status changed from New to In progress
Updated by Alexis Mousset over 7 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Alexis Mousset to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/rudder-packages/pull/1284
Updated by François ARMAND over 7 years ago
- Related to User story #10366: Add expiration on static resources added
Updated by Alexis Mousset over 7 years ago
- Status changed from Pending technical review to New
We would need to add a version parameter in URLs of the index.html to avoid trouble.
Updated by Alexis Mousset over 7 years ago
- Subject changed from Add expires on static content in apache conf to Add expires on static content ncf builder
- Assignee deleted (
Benoît PECCATTE) - Target version deleted (
4.1.0)
Updated by Alexis Mousset over 7 years ago
- Suggestion strength set to Advise - This would make Rudder significantly better | easier | simpler
- Effort required set to Medium
- Pull Request deleted (
https://github.com/Normation/rudder-packages/pull/1284)
Updated by François ARMAND over 7 years ago
I believe they have a cache version, or I'm missing something?
In /rudder/index.html (login page):
...
<link href="/rudder/cache-4.1.0~rc2-SNAPSHOT/images/rudder-favicon.ico" type="image/x-icon" rel="icon">
<script src="/rudder/cache-4.1.0~rc2-SNAPSHOT/javascript/jquery/jquery-3.1.0.min.js" type="text/javascript"></script>
...
<img src="/rudder/cache-4.1.0~rc2-SNAPSHOT/images/login/logo-rudder.svg" alt="Rudder">
And in rudder/secure/index.html
...
<link href="/rudder/cache-4.1.0~rc2-SNAPSHOT/style/rudder/rudder-menu.css" rel="stylesheet" type="text/css">
<script src="/rudder/cache-4.1.0~rc2-SNAPSHOT/javascript/utils/WeakMap.js" type="text/javascript"></script>
...
And in all cases, only the path with the cache version get the cache headers.
Updated by Alexis Mousset over 7 years ago
This ticket is about ncf-builder, I don't think it currently have a version number in URLs
Updated by Benoît PECCATTE almost 7 years ago
- Target version set to Ideas (not version specific)
Updated by Alexis Mousset over 3 years ago
- Status changed from New to Rejected
No more separate ncf-builder
Actions