User story #10368: Add expires on static content ncf builder - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open issues 8.0
Open UX defects (all)
Opened by users

Actions

Copy link

User story #10368

closed

Add expires on static content ncf builder

Added by Alexis Mousset about 7 years ago. Updated about 3 years ago.

Status:

Rejected

Priority:

N/A

Assignee:

Category:

Packaging

Target version:

Ideas (not version specific)

Pull Request:

UX impact:

Suggestion strength:

Advise - This would make Rudder significantly better | easier | simpler

User visibility:

Effort required:

Medium

Name check:

Fix check:

Regression:

Description

Add expires on static content of the builder.

Related issues 1 (0 open — 1 closed)

Related to Rudder - User story #10366: Add expiration on static resources

Rejected

Benoît PECCATTE

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Status changed from New to In progress
Assignee set to Alexis Mousset

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Project changed from 41 to Rudder
Category changed from Packaging to Packaging
Status changed from In progress to New
Target version changed from 1.0 to 4.1.0

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Status changed from In progress to Pending technical review
Assignee changed from Alexis Mousset to Benoît PECCATTE
Pull Request set to https://github.com/Normation/rudder-packages/pull/1284

PR https://github.com/Normation/rudder-packages/pull/1284

Actions

Copy link

Updated by François ARMAND about 7 years ago

Related to User story #10366: Add expiration on static resources added

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Status changed from Pending technical review to New

We would need to add a version parameter in URLs of the index.html to avoid trouble.

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Subject changed from Add expires on static content in apache conf to Add expires on static content ncf builder
Assignee deleted (~~Benoît PECCATTE~~)
Target version deleted (~~4.1.0~~)

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Suggestion strength set to Advise - This would make Rudder significantly better | easier | simpler
Effort required set to Medium
Pull Request deleted (~~https://github.com/Normation/rudder-packages/pull/1284~~)

Actions

Copy link

Updated by François ARMAND about 7 years ago

I believe they have a cache version, or I'm missing something?

In /rudder/index.html (login page):

...
    <link href="/rudder/cache-4.1.0~rc2-SNAPSHOT/images/rudder-favicon.ico" type="image/x-icon" rel="icon">
    <script src="/rudder/cache-4.1.0~rc2-SNAPSHOT/javascript/jquery/jquery-3.1.0.min.js" type="text/javascript"></script>
...
    <img src="/rudder/cache-4.1.0~rc2-SNAPSHOT/images/login/logo-rudder.svg" alt="Rudder">

And in rudder/secure/index.html

...
    <link href="/rudder/cache-4.1.0~rc2-SNAPSHOT/style/rudder/rudder-menu.css" rel="stylesheet" type="text/css">
    <script src="/rudder/cache-4.1.0~rc2-SNAPSHOT/javascript/utils/WeakMap.js" type="text/javascript"></script>
...

And in all cases, only the path with the cache version get the cache headers.

Actions

Copy link

#10