Project

General

Profile

Actions

User story #10412

closed

Add a convention for ".disabled" hooks to not be executed

Added by François ARMAND over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
N/A
Category:
-
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

In #8353, we added hooks. It was decided at the time that we will choose which scripts to execute based on the exec bit of the file. It means that to disable a script, you "set -x" it.

Now, there is a commonly used convention that in that kind of context, a ".disabled" script will not be executed even if it is set +x.

To be more general, it should be a list of excluded extension, which could also takes care of "rpmnew" and other things.

The documentation will need to be updated accordingly.

The list of suffixes that will make a hook be ignored is defined in /opt/rudder/etc/rudder-web.properties => rudder.hooks.ignore-suffixes


Subtasks 1 (0 open1 closed)

User story #10425: Add migration script for hooks ignore suffixesReleasedVincent MEMBRÉActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #10379: When upgrading to 4.1, rudder.community.checkpromises.command=/bin/true option is lost ReleasedAlexis MoussetActions
Actions #1

Updated by François ARMAND over 7 years ago

  • Description updated (diff)
Actions #2

Updated by François ARMAND over 7 years ago

  • Related to Bug #10379: When upgrading to 4.1, rudder.community.checkpromises.command=/bin/true option is lost added
Actions #3

Updated by François ARMAND over 7 years ago

  • Target version set to 4.1.0
Actions #4

Updated by François ARMAND over 7 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #5

Updated by François ARMAND over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1592
Actions #6

Updated by François ARMAND over 7 years ago

  • Description updated (diff)
Actions #7

Updated by François ARMAND over 7 years ago

  • Status changed from Pending technical review to Pending release
Actions #8

Updated by Benoît PECCATTE over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.0 which was released today.

Actions

Also available in: Atom PDF