https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182017-04-07T09:56:45ZIssue TrackerRudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=747132017-04-07T09:56:45ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In progress</i></li><li><strong>Assignee</strong> set to <i>François ARMAND</i></li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=747232017-04-07T16:52:00ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>I need a precision for the return code 100 for pre-hook.</p>
<p>For now, I understand the semantic as:</p>
<ul>
<li>execution of the hook is successful - the script did what it was supposed to do, </li>
<li>do NOT process latter hooks - as if it was an error - and so must be the last hook to be used as a guard, </li>
<li>returned a custom, specialized non-error message to the used explaining that all the hook where executed until the one returning 100 which prevented the node to be deleted because "hook message"</li>
</ul>
<p>Is this that? I don't see how any other semantic plays well will the hook flow (especially if we choose to continue forward in the case of 100) - but I can just be missing the use case / semantic.</p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=747242017-04-07T17:13:48ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>Work in progess here: <a class="external" href="https://github.com/fanf/rudder/commit/09e3f54538b7848f01784dfb8224af13aef22fbd">https://github.com/fanf/rudder/commit/09e3f54538b7848f01784dfb8224af13aef22fbd</a></p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=747252017-04-07T17:15:52ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>New</i></li><li><strong>Assignee</strong> deleted (<del><i>François ARMAND</i></del>)</li></ul><p>I can't work anymore on that for the coming week.</p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=747902017-04-12T16:55:36ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>Work in progess here: <a class="external" href="https://github.com/VinceMacBuche/rudder/commit/b4306efe7979cb4a1d0b8179c65e24b3ac746a1e">https://github.com/VinceMacBuche/rudder/commit/b4306efe7979cb4a1d0b8179c65e24b3ac746a1e</a></p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=748312017-04-13T17:24:12ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>Work in progess here: <a class="external" href="https://github.com/VinceMacBuche/rudder/commit/53686fa6f3a6431b93f955a7dc0236f3711bc95b">https://github.com/VinceMacBuche/rudder/commit/53686fa6f3a6431b93f955a7dc0236f3711bc95b</a></p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=752652017-04-14T15:11:48ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Target version</strong> changed from <i>4.1.1</i> to <i>4.1.2</i></li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=752882017-04-14T15:21:24ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> set to <i>Nicolas CHARLES</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder/pull/1629</i></li></ul><p>PR <a class="external" href="https://github.com/Normation/rudder/pull/1629">https://github.com/Normation/rudder/pull/1629</a></p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=754612017-04-19T16:49:44ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Assignee</strong> changed from <i>Nicolas CHARLES</i> to <i>François ARMAND</i></li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=755102017-04-20T17:09:36ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Assignee</strong> changed from <i>François ARMAND</i> to <i>Nicolas CHARLES</i></li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=755432017-04-21T15:12:23ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Assignee</strong> changed from <i>Nicolas CHARLES</i> to <i>François ARMAND</i></li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=755492017-04-21T15:26:23ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li></ul><p>Applied in changeset <a class="changeset" title="Fixes #10568: Create a hook for pre and post node deletion event" href="https://issues.rudder.io/projects/rudder/repository/rudder/revisions/7f26d75c230f7421d36214efc0aa1841f4f3fdaf">rudder|7f26d75c230f7421d36214efc0aa1841f4f3fdaf</a>.</p> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=761962017-05-09T14:35:31ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-16 priority-default closed parent" href="/issues/8353">User story #8353</a>: Implement notifications for different server-side actions and events (hooks)</i> added</li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=762072017-05-10T09:38:02ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-6 priority-16 priority-default closed" href="/issues/10724">User story #10724</a>: adding a Hook after node validation</i> added</li></ul> Rudder - User story #10568: Create a hook for pre and post node deletion eventhttps://issues.rudder.io/issues/10568?journal_id=768272017-05-22T13:51:51ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 4.1.2 which was released today.</p>
<ul>
<li>4.1.2: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-May/thread.html000230.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-4.1" class="external">Changelog</a></li>
<li>Download: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul>