Project

General

Profile

Bug #10599

Impossible to search or build groups based on JSON values in node properties

Added by Vincent MEMBRÉ over 1 year ago. Updated about 1 year ago.

Status:
Released
Priority:
N/A
Category:
Web - Nodes & inventories
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Medium
Priority:
60
Tags:

Description

You can only look for "string" node properties and not for "json" node properties to build your groups

This may need quite an important refactoring on how to do request on json data in the LDAP


Subtasks

Bug #11751: Impossible to search or build groups based on JSON values in node propertiesReleasedVincent MEMBRÉ

Related issues

Related to Rudder - Bug #9299: Extend groups search capabilities for complex JSON Properties / JsonPathPending release
Related to Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valueReleased
Related to Rudder - Bug #11168: Search believe that CFEngine agents with "dsc" in their keys are also DSC agent Released
Has duplicate Rudder - Bug #10743: Dynamic group search not available on boolean node property valueRejected

Associated revisions

Revision ff88381d (diff)
Added by François ARMAND about 1 year ago

Issue #10599: split different json usage in different comparators

Revision 2b5f456c (diff)
Added by François ARMAND about 1 year ago

Issue #10599: split different json usage in different comparators

Revision 959f66ec (diff)
Added by François ARMAND about 1 year ago

Fixes #10599: Impossible to search or build groups based on JSON values in node properties

Revision 3e9d17b3 (diff)
Added by François ARMAND about 1 year ago

Fixes #10599: Impossible to search or build groups based on JSON values in node properties

History

#1 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.19 to 3.1.20

#2 Updated by Janos Mattyasovszky over 1 year ago

This is probably the same as #9299 since a dynamic group is basically defined by a search... ;-)

#3 Updated by François ARMAND over 1 year ago

  • Related to Bug #9299: Extend groups search capabilities for complex JSON Properties / JsonPath added

#4 Updated by François ARMAND over 1 year ago

  • Tags set to Sponsored
  • Severity set to Critical - prevents main use of Rudder | no workaround | data loss | security
  • User visibility set to Getting started - demo | first install | level 1 Techniques

Janos Matya: it's worse. Even the bad simple use case is broken today.

#5 Updated by François ARMAND over 1 year ago

  • Related to Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid value added

#6 Updated by François ARMAND over 1 year ago

  • Related to Bug #10605: Sharing files with "root" does not work added

#7 Updated by François ARMAND over 1 year ago

  • Related to deleted (Bug #10605: Sharing files with "root" does not work)

#8 Updated by François ARMAND over 1 year ago

  • Severity changed from Critical - prevents main use of Rudder | no workaround | data loss | security to Major - prevents use of part of Rudder | no simple workaround
  • User visibility changed from Getting started - demo | first install | level 1 Techniques to Operational - other Techniques | Technique editor | Rudder settings

#9 Updated by Jonathan CLARKE over 1 year ago

  • Subject changed from Impossible to search a json value in Node property to Impossible to search or build groups based on JSON values in node properties
  • Priority changed from 0 to 61

#10 Updated by François ARMAND over 1 year ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND

#11 Updated by François ARMAND over 1 year ago

  • Effort required set to Medium
  • Priority changed from 61 to 60

So in fact, it is not that simple because the backend code is a mess. We need to spend some time cleaning up a little the logic, split the other simple case of the JsonComparotor to build a new one more potent able to manage JSON value without breaking other part of Rudder.

And it will bring side benefits like better error message when the user it not using these fields as expected.

It may not be too risky (and so still be doable in 3.1 without any behavior change), but it is tedious and will take some time.

#12 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#13 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.21 to 3.1.22
  • Priority changed from 60 to 59

#14 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.22 to 3.1.23
  • Priority changed from 59 to 57

#15 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.23 to 3.1.24

#16 Updated by François ARMAND about 1 year ago

  • Related to Bug #11168: Search believe that CFEngine agents with "dsc" in their keys are also DSC agent added

#17 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.24 to 3.1.25
  • Priority changed from 57 to 55

#18 Updated by François ARMAND about 1 year ago

  • Priority changed from 55 to 61

#19 Updated by François ARMAND about 1 year ago

  • Target version changed from 3.1.25 to 4.1.9

Won't correct that in 3.1

#20 Updated by François ARMAND about 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1781

#21 Updated by François ARMAND about 1 year ago

  • Related to Bug #10743: Dynamic group search not available on boolean node property value added

#22 Updated by François ARMAND about 1 year ago

  • Related to deleted (Bug #10743: Dynamic group search not available on boolean node property value)

#23 Updated by François ARMAND about 1 year ago

  • Has duplicate Bug #10743: Dynamic group search not available on boolean node property value added

#24 Updated by François ARMAND about 1 year ago

  • Status changed from Pending technical review to Pending release

#25 Updated by Vincent MEMBRÉ about 1 year ago

  • Status changed from Pending release to Released
  • Priority changed from 61 to 60

This bug has been fixed in Rudder 4.1.9 and 4.2.3 which were released today.

Also available in: Atom PDF