Project

General

Profile

Actions
Copy link

Bug #10599

closed

Impossible to search or build groups based on JSON values in node properties

Bug #10599: Impossible to search or build groups based on JSON values in node properties

Added by Vincent MEMBRÉ about 9 years ago. Updated almost 4 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Web - Nodes & inventories
Target version:
4.1.9
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Medium
Priority:
0
Name check:
Fix check:
Regression:

Description

You can only look for "string" node properties and not for "json" node properties to build your groups

This may need quite an important refactoring on how to do request on json data in the LDAP

Subtasks 1 (0 open — 1 closed)

Bug #11751: Impossible to search or build groups based on JSON values in node propertiesReleasedVincent MEMBRÉActions

Related issues 4 (0 open — 4 closed)

Related to Rudder - Bug #9299: Extend groups search capabilities for complex JSON Properties / JsonPathReleasedVincent MEMBRÉActions
Related to Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valueReleasedFrançois ARMANDActions
Related to Rudder - Bug #11168: Search believe that CFEngine agents with "dsc" in their keys are also DSC agent ReleasedFrançois ARMANDActions
Has duplicate Rudder - Bug #10743: Dynamic group search not available on boolean node property valueRejectedActions

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #1

  • Target version changed from 3.1.19 to 3.1.20

Updated by Janos Mattyasovszky almost 9 years ago Actions
Copy link
 #2

This is probably the same as #9299 since a dynamic group is basically defined by a search... ;-)

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #3

  • Related to Bug #9299: Extend groups search capabilities for complex JSON Properties / JsonPath added

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #4

  • Translation missing: en.field_tag_list set to Sponsored
  • Severity set to Critical - prevents main use of Rudder | no workaround | data loss | security
  • User visibility set to Getting started - demo | first install | level 1 Techniques

@janos: it's worse. Even the bad simple use case is broken today.

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #5

  • Related to Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid value added

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #6

  • Related to Bug #10605: Sharing files with "root" does not work added

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #7

  • Related to deleted (Bug #10605: Sharing files with "root" does not work)

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #8

  • Severity changed from Critical - prevents main use of Rudder | no workaround | data loss | security to Major - prevents use of part of Rudder | no simple workaround
  • User visibility changed from Getting started - demo | first install | level 1 Techniques to Operational - other Techniques | Technique editor | Rudder settings

Updated by Jonathan CLARKE almost 9 years ago Actions
Copy link
 #9

  • Subject changed from Impossible to search a json value in Node property to Impossible to search or build groups based on JSON values in node properties
  • Priority changed from 0 to 61

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #10

  • Status changed from New to In progress
  • Assignee set to François ARMAND

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #11

  • Effort required set to Medium
  • Priority changed from 61 to 60

So in fact, it is not that simple because the backend code is a mess. We need to spend some time cleaning up a little the logic, split the other simple case of the JsonComparotor to build a new one more potent able to manage JSON value without breaking other part of Rudder.

And it will bring side benefits like better error message when the user it not using these fields as expected.

It may not be too risky (and so still be doable in 3.1 without any behavior change), but it is tedious and will take some time.

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #12

  • Target version changed from 3.1.20 to 3.1.21

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #13

  • Target version changed from 3.1.21 to 3.1.22
  • Priority changed from 60 to 59

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #14

  • Target version changed from 3.1.22 to 3.1.23
  • Priority changed from 59 to 57

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #15

  • Target version changed from 3.1.23 to 3.1.24

Updated by François ARMAND over 8 years ago Actions
Copy link
 #16

  • Related to Bug #11168: Search believe that CFEngine agents with "dsc" in their keys are also DSC agent added

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #17

  • Target version changed from 3.1.24 to 3.1.25
  • Priority changed from 57 to 55

Updated by François ARMAND over 8 years ago Actions
Copy link
 #18

  • Priority changed from 55 to 61

Updated by François ARMAND over 8 years ago Actions
Copy link
 #19

  • Target version changed from 3.1.25 to 4.1.9

Won't correct that in 3.1

Updated by François ARMAND over 8 years ago Actions
Copy link
 #20

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1781

Updated by François ARMAND over 8 years ago Actions
Copy link
 #21

  • Related to Bug #10743: Dynamic group search not available on boolean node property value added

Updated by François ARMAND over 8 years ago Actions
Copy link
 #22

  • Related to deleted (Bug #10743: Dynamic group search not available on boolean node property value)

Updated by François ARMAND over 8 years ago Actions
Copy link
 #23

  • Has duplicate Bug #10743: Dynamic group search not available on boolean node property value added

Updated by François ARMAND over 8 years ago Actions
Copy link
 #24

  • Status changed from Pending technical review to Pending release

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #25

  • Status changed from Pending release to Released
  • Priority changed from 61 to 60

This bug has been fixed in Rudder 4.1.9 and 4.2.3 which were released today.

Updated by Alexis Mousset almost 4 years ago Actions
Copy link
 #26

  • Priority changed from 60 to 0
Actions
Copy link

Also available in: PDF Atom