Project

General

Custom queries

Profile

Actions
Copy link

Bug #10601

closed

If component value starts with # , report is not outputed by rudder agent output

Added by Nicolas CHARLES about 8 years ago. Updated about 8 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Agent
Target version:
4.0.7
Pull Request:
https://github.com/Normation/rudder-a...
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Small
Priority:
67
Name check:
Fix check:
Regression:

Description

If a component value starts with #, the output is not correctly parsed by command rudder agent
Example:

R: @@sshKeyDistribution@@result_success@@uuid@@uuid@@SSH key@@# my key@@2017-04-13 12:31:32+00:00##uuid@#SSH key "# my key" for user was correct

it conflict with the last @#

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #8862: Broken agent parsing when some report data start or ends with a separator charRejectedActions
Related to Rudder - Architecture #10648: Use the same regex as rsyslog to parse Rudder reportsRejectedActions
Actions
Copy link
 #5

Updated by Alexis Mousset about 8 years ago

  • Effort required set to Small
  • Priority changed from 60 to 68

We can try to make a second split instead og change the whole parsing.

Actions
Copy link
 #7

Updated by Alexis Mousset about 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-agent/pull/113
Actions
Copy link
 #9

Updated by Alexis Mousset about 8 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ about 8 years ago

  • Status changed from Pending release to New
Actions
Copy link
 #11

Updated by Nicolas CHARLES about 8 years ago

This was not correctly reverted !
In 4.1 nightly: 

BEGIN {
  FS = "[^@]@#";

Actions
Copy link
 #13

Updated by Vincent MEMBRÉ about 8 years ago

Thiw was revert in 4.0 and 4.1 here : rudder-agent|82f99d4f

Actions
Copy link
 #14

Updated by Benoît PECCATTE about 8 years ago

  • Target version changed from 3.1.21 to 4.0.7

Let's fix this in 4.0 first

Actions
Copy link
 #16

Updated by Benoît PECCATTE about 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis Mousset
  • Pull Request changed from https://github.com/Normation/rudder-agent/pull/113 to https://github.com/Normation/rudder-agent/pull/116
Actions
Copy link
 #18

Updated by Benoît PECCATTE about 8 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #19

Updated by Alexis Mousset about 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.7 which was released today.

Actions
Copy link

Also available in: Atom PDF