Project

General

Profile

Actions

Bug #10908

closed

When hooks in policy-generation-node-ready or policy-generation-node-finished fails, there is no error in the generation

Added by Nicolas CHARLES almost 7 years ago. Updated almost 7 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

Error codes of hooks in policy-generation-node-ready or policy-generation-node-finished are not handled: if we return 1, it happily continues generation and finishes

It seems it's because return code is encapsulated in a Full - so it's always ok
So there is no real check on policy generation validity

Actions #1

Updated by François ARMAND almost 7 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #2

Updated by François ARMAND almost 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/1664
Actions #3

Updated by François ARMAND almost 7 years ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Alexis Mousset almost 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.4 which was not released (see changelog for details), and is available in Rudder 4.1.5.

Actions

Also available in: Atom PDF