Project

General

Profile

Bug #10973

When hooks are exiting with an error we can have stackoverflow error if there are many of them

Added by Nicolas CHARLES about 2 years ago. Updated 7 months ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Medium
Priority:
29

Description

I have an install with 1600 nodes
I had a stackoverflow error at generation - increasing Xss to 128m allowed me to circumvent the issue
The I got thousands of

stderr: '2017-06-21T18:21:55+0200 error: Can't stat file '/var/rudder/ncf//bin/sh: 0: Can't open /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs' for parsing. (stat: No such file or directory) ' ; Exit code=1 for hook: '/opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check'. stdout: stderr: '2017-06-21T18:21:55+0200 error: Can't stat file '/var/rudder/ncf//bin/sh: 0: Can't open /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs' for parsing. (stat: No such file or directory) ' ; Exit code=1 for hook: '/opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check'. stdout: stderr: '2017-06-21T18:21:55+0200 error: Can't stat file '/var/rudder/ncf//bin/sh: 0: Can't open /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs' for parsing. (stat: No such file or directory) ' ; Exit code=1 for hook: '/opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check'.

as you can see, the nodeid is missing there

Associated revisions

Revision 283178c3 (diff)
Added by François ARMAND 7 months ago

Fixes #10973: When hooks are exiting an error we can have stackoverfloww error if there are many of them

History

#1

Updated by Alexis MOUSSET about 2 years ago

  • Target version changed from 4.1.5 to 4.1.6
#2

Updated by Benoît PECCATTE about 2 years ago

  • Effort required set to Very Small
  • Priority changed from 0 to 58
#3

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 4.1.6 to 4.1.7
  • Priority changed from 58 to 57
#4

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 4.1.7 to 4.1.8
  • Priority changed from 57 to 56
#5

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 4.1.8 to 4.1.9
  • Priority changed from 56 to 55
#6

Updated by Benoît PECCATTE almost 2 years ago

  • Priority changed from 55 to 66
#7

Updated by François ARMAND over 1 year ago

  • Assignee set to François ARMAND
  • Priority changed from 66 to 65
#8

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.1.9 to 4.1.10
#9

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 65 to 62
#10

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 62 to 60
#11

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 4.1.12 to 4.1.13
  • Priority changed from 60 to 59
#12

Updated by Benoît PECCATTE over 1 year ago

  • Target version changed from 4.1.13 to 411
#13

Updated by Benoît PECCATTE over 1 year ago

  • Target version changed from 411 to 4.1.13
#14

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 4.1.13 to 4.1.14
  • Priority changed from 59 to 58
#15

Updated by Benoît PECCATTE about 1 year ago

  • Target version changed from 4.1.14 to 4.1.15
#16

Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 4.1.15 to 4.1.16
#17

Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 4.1.16 to 4.1.17
#18

Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 4.1.17 to 4.1.18
#19

Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 4.1.18 to 4.1.19
#20

Updated by François ARMAND 7 months ago

  • Subject changed from When hooks are exiting an error, we don't get the node that is failing, and we can have stackoverfloww error if there are many of them to When hooks are exiting an error we can have stackoverfloww error if there are many of them
  • User visibility changed from Infrequent - complex configurations | third party integrations to Operational - other Techniques | Rudder settings | Plugins
  • Effort required changed from Very Small to Medium
  • Priority changed from 58 to 29

I'm take that "very small" is to look at the real weight.

#21

Updated by François ARMAND 7 months ago

  • Status changed from New to In progress
#22

Updated by François ARMAND 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2112
#23

Updated by Rudder Quality Assistant 7 months ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
#24

Updated by François ARMAND 7 months ago

  • Status changed from Pending technical review to Pending release
#25

Updated by Alexis MOUSSET 7 months ago

  • Subject changed from When hooks are exiting an error we can have stackoverfloww error if there are many of them to When hooks are exiting with an error we can have stackoverflow error if there are many of them
#26

Updated by Alexis MOUSSET 7 months ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.19, 4.3.9 and 5.0.5 which were released today.
Changelog
Changelog
Changelog

Also available in: Atom PDF