Project

General

Profile

Actions
Copy link

Bug #10973

closed

When hooks are exiting with an error we can have stackoverflow error if there are many of them

Added by Nicolas CHARLES over 7 years ago. Updated almost 6 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Web - Config management
Target version:
4.1.19
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Medium
Priority:
29
Name check:
Fix check:
Regression:

Description

I have an install with 1600 nodes
I had a stackoverflow error at generation - increasing Xss to 128m allowed me to circumvent the issue
The I got thousands of 

stderr: '2017-06-21T18:21:55+0200 error: Can't stat file '/var/rudder/ncf//bin/sh: 0: Can't open /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs' for parsing. (stat: No such file or directory) ' ; Exit code=1 for hook: '/opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check'. stdout: stderr: '2017-06-21T18:21:55+0200 error: Can't stat file '/var/rudder/ncf//bin/sh: 0: Can't open /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs' for parsing. (stat: No such file or directory) ' ; Exit code=1 for hook: '/opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check'. stdout: stderr: '2017-06-21T18:21:55+0200 error: Can't stat file '/var/rudder/ncf//bin/sh: 0: Can't open /var/rudder/ncf/common/10_ncf_internals/list-compatible-inputs' for parsing. (stat: No such file or directory) ' ; Exit code=1 for hook: '/opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check'.

as you can see, the nodeid is missing there

Actions
Copy link
 #1

Updated by Alexis Mousset over 7 years ago

  • Target version changed from 4.1.5 to 4.1.6
Actions
Copy link
 #2

Updated by Benoît PECCATTE over 7 years ago

  • Effort required set to Very Small
  • Priority changed from 0 to 58
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.1.6 to 4.1.7
  • Priority changed from 58 to 57
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.1.7 to 4.1.8
  • Priority changed from 57 to 56
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.1.8 to 4.1.9
  • Priority changed from 56 to 55
Actions
Copy link
 #6

Updated by Benoît PECCATTE about 7 years ago

  • Priority changed from 55 to 66
Actions
Copy link
 #7

Updated by François ARMAND almost 7 years ago

  • Assignee set to François ARMAND
  • Priority changed from 66 to 65
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.1.9 to 4.1.10
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 65 to 62
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 62 to 60
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
  • Priority changed from 60 to 59
Actions
Copy link
 #12

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 4.1.13 to 411
Actions
Copy link
 #13

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 411 to 4.1.13
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.13 to 4.1.14
  • Priority changed from 59 to 58
Actions
Copy link
 #15

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.17 to 4.1.18
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions
Copy link
 #20

Updated by François ARMAND almost 6 years ago

  • Subject changed from When hooks are exiting an error, we don't get the node that is failing, and we can have stackoverfloww error if there are many of them to When hooks are exiting an error we can have stackoverfloww error if there are many of them
  • User visibility changed from Infrequent - complex configurations | third party integrations to Operational - other Techniques | Rudder settings | Plugins
  • Effort required changed from Very Small to Medium
  • Priority changed from 58 to 29

I'm take that "very small" is to look at the real weight.

Actions
Copy link
 #21

Updated by François ARMAND almost 6 years ago

  • Status changed from New to In progress
Actions
Copy link
 #22

Updated by François ARMAND almost 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2112
Actions
Copy link
 #23

Updated by Rudder Quality Assistant almost 6 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #24

Updated by François ARMAND almost 6 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #25

Updated by Alexis Mousset almost 6 years ago

  • Subject changed from When hooks are exiting an error we can have stackoverfloww error if there are many of them to When hooks are exiting with an error we can have stackoverflow error if there are many of them
Actions
Copy link
 #26

Updated by Alexis Mousset almost 6 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.19, 4.3.9 and 5.0.5 which were released today. 
Changelog
 Changelog
 Changelog
Actions
Copy link

Also available in: Atom PDF