Project

General

Profile

Actions
Copy link

Architecture #11027

closed

We are identifying agent runs based on hasPolicyServer-*, which is inefficient, and invalid

Added by Nicolas CHARLES over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Web - Compliance & node report
Target version:
4.2.0~beta2
Pull Request:
https://github.com/Normation/rudder/p...
Effort required:
Small
Name check:
Fix check:
Regression:

Description

Only nodes with rule hasPolicyServer-* can have their reports processed by the webapp
However dsc nodes don't have this rule, so they rely on a hack to work

We ought to change the getRunsQuery in ReportsJdbcRepository to:
  • remove the hasPolicyServer%
  • filter on control report type

so that it would work everywhere

Subtasks 3 (0 open — 3 closed)

Architecture #11039: Update start/end reports in rudder techniquesReleasedAlexis MoussetActions
Architecture #11085: Adapt CLI to accept new end run formatReleasedNicolas CHARLESActions
Architecture #11100: Same as 11085 for 4.1ReleasedNicolas CHARLESActions
Actions
Copy link
 #1

Updated by Nicolas CHARLES over 7 years ago

we ùay need to add an index on eventtype (but that's not even sure) or eventtype = 'log_info'

Actions
Copy link
 #2

Updated by Benoît PECCATTE over 7 years ago

  • Tracker changed from Bug to Architecture
  • Subject changed from We are identifying agent runs based on hasPolicyServer-*, which is unefficient, and invalid to We are identifying agent runs based on hasPolicyServer-*, which is inefficient, and invalid
Actions
Copy link
 #4

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #5

Updated by Nicolas CHARLES over 7 years ago

  • Description updated (diff)

We decided to change the format of reports to
severity: control
technique : rudder
directive: run
serial: 0
rule: rudder
component: end/start
value : $configid

Actions
Copy link
 #6

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/1688
Actions
Copy link
 #7

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.2.0~beta2 which was released today.

Actions
Copy link

Also available in: Atom PDF