Bug #11326: chars are not escaped correctly in dsc techniques - Rudder - Issue Tracker

Actions

Bug #11326

closed

chars are not escaped correctly in dsc techniques

Added by Félix DALLIDET over 7 years ago. Updated about 7 years ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

Web - Config management

Target version:

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Critical - prevents main use of Rudder | no workaround | data loss | security

UX impact:

User visibility:

Operational - other Techniques | Technique editor | Rudder settings

Effort required:

Priority:

76

Name check:

Fix check:

Regression:

Description

As in https://www.rudder-project.org/redmine/issues/11268 but for dsc techniques.
Escaping is done with "\" but should be done with "`"

Subtasks 2 (0 open — 2 closed)

Actions

#1

Updated by François ARMAND over 7 years ago

Severity set to Critical - prevents main use of Rudder | no workaround | data loss | security
User visibility set to Operational - other Techniques | Technique editor | Rudder settings
Priority changed from 0 to 76

The escaping must not be done in JS but at (CFEngine, DSC) generation time, in ncf. We need to have the real, raw input data to be able to correctly escape for each targetted agent language.

Actions

#2

Updated by François ARMAND over 7 years ago

Project changed from Rudder to 41
Category set to Technique editor - API
Target version set to master

Actions

#3

Updated by Vincent MEMBRÉ over 7 years ago

Status changed from New to In progress
Assignee set to Vincent MEMBRÉ

Actions

#4

Updated by Vincent MEMBRÉ over 7 years ago

Status changed from In progress to Pending technical review
Assignee changed from Vincent MEMBRÉ to François ARMAND
Pull Request set to https://github.com/Normation/rudder/pull/1736

PR https://github.com/Normation/rudder/pull/1736

Actions

#5

Updated by Vincent MEMBRÉ over 7 years ago

Project changed from 41 to Rudder
Category changed from Technique editor - API to Web - Config management
Target version changed from master to 4.2.0~rc2

Actions

#6

Updated by Vincent MEMBRÉ over 7 years ago

Pull Request deleted (~~https://github.com/Normation/rudder/pull/1736~~)

Actions

#7

Updated by Vincent MEMBRÉ over 7 years ago

Pull Request set to https://github.com/Normation/rudder/pull/1737

PR https://github.com/Normation/rudder/pull/1737

Actions

#8

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 4.2.0~rc2 to 4.2.0

Actions

#9

Updated by Vincent MEMBRÉ over 7 years ago

Status changed from Pending technical review to Pending release

Applied in changeset rudder|891338ec125fb0f811e9548802f2411badb30339.

Actions

#10

Updated by Vincent MEMBRÉ about 7 years ago

Status changed from Pending release to Released

This bug has been fixed in Rudder 4.2.0 which was released today.

4.2.0: Announce Changelog
Download: https://www.rudder-project.org/site/get-rudder/downloads/

Actions

Also available in: Atom PDF