Project

General

Profile

Bug #11417

Command "rudder remote run -a" does not warn about missing token

Added by Janos Mattyasovszky about 1 year ago. Updated 17 days ago.

Status:
Released
Priority:
N/A
Category:
Agent
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
0

Description

When running rudder remote run -a, it does not show the error message if missing a token.

(review noteE: the correct command is: rudder remote run -at token
Any other combinaison (notably -a -t ) fails, at least on centos 7)

bash -x revealed:

+ full_api_call /api/nodes '' '' ''
[cut]
++ _get_conf '' token
++ conf=
++ name=token
++ conffile=/root/.rudder
++ '[' -f /root/.rudder ']'
++ return
+ token=
+ '[' -z '' ']'
+ echo 'A token is mandatory to query the server'
+ exit 1
parse error: Invalid numeric literal at line 1, column 2
error    Rudder agent was interrupted during execution by a fatal error
         Run with -i to see log messages.

## Summary #####################################################################
0 components verified in 0 directives
execution time: 0.01s
################################################################################

Recommending that the error message echo "A token is mandatory to query the server" is shown on stderr and that a sanity-check is run before full_api_call is actually used as input for a pipe, so that a valid pre-execution error message can be displayed to the user instead of guessing what "parse error: Invalid numeric literal at line 1, column 2" actually hides.

ver 4.1.7-2 sles11


Related issues

Related to Rudder - Bug #13897: Command "rudder remote run" must accept "-a -t" Rejected

Associated revisions

Revision 21175059 (diff)
Added by Félix DALLIDET about 1 month ago

Fixes #11417: rudder remote run -a does not show error message for missing token

History

#1 Updated by François ARMAND about 1 year ago

  • Target version set to 3.1.24
  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility changed from First impressions of Rudder to Operational - other Techniques | Technique editor | Rudder settings
  • Effort required set to Very Small
  • Priority changed from 0 to 49

#2 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.24 to 3.1.25

#3 Updated by Benoît PECCATTE about 1 year ago

  • Priority changed from 49 to 61

#4 Updated by Benoît PECCATTE about 1 year ago

  • Target version changed from 3.1.25 to 4.1.9

#5 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 4.1.9 to 4.1.10
  • Priority changed from 61 to 60

#6 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 60 to 57

#7 Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 57 to 56

#8 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 4.1.12 to 4.1.13
  • Priority changed from 56 to 55

#9 Updated by Benoît PECCATTE 7 months ago

  • Target version changed from 4.1.13 to 411

#10 Updated by Benoît PECCATTE 7 months ago

  • Target version changed from 411 to 4.1.13

#11 Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 4.1.13 to 4.1.14
  • Priority changed from 55 to 53

#12 Updated by Benoît PECCATTE 4 months ago

  • Target version changed from 4.1.14 to 4.1.15
  • Priority changed from 53 to 52

#13 Updated by Vincent MEMBRÉ about 2 months ago

  • Target version changed from 4.1.15 to 4.1.16
  • Priority changed from 52 to 51

#14 Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 4.1.16 to 4.1.17

#15 Updated by Félix DALLIDET about 1 month ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
  • Priority changed from 51 to 0

#16 Updated by Félix DALLIDET about 1 month ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-agent/pull/196

#17 Updated by Félix DALLIDET about 1 month ago

  • Status changed from Pending technical review to Pending release

#18 Updated by Nicolas CHARLES 28 days ago

I struggled to check that it work. On a centos7 (at least), the proper command to run remote is
rudder remote run -at token
any other combinaison (notably -a -t ) fails on centos7

#19 Updated by François ARMAND 20 days ago

  • Subject changed from rudder remote run -a does not show error message for missing token to Command "rudder remote run -a" does not warn about missing token
  • Description updated (diff)

#20 Updated by François ARMAND 20 days ago

  • Related to Bug #13897: Command "rudder remote run" must accept "-a -t" added

#21 Updated by Vincent MEMBRÉ 17 days ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.17, 4.3.7 and 5.0.3 which were released today.
Changelog
Changelog
Changelog

Also available in: Atom PDF