Bug #11417
closedCommand "rudder remote run -a" does not warn about missing token
Description
When running rudder remote run -a
, it does not show the error message if missing a token.
(review noteE: the correct command is: rudder remote run -at token
Any other combinaison (notably -a -t ) fails, at least on centos 7)
bash -x revealed:
+ full_api_call /api/nodes '' '' '' [cut] ++ _get_conf '' token ++ conf= ++ name=token ++ conffile=/root/.rudder ++ '[' -f /root/.rudder ']' ++ return + token= + '[' -z '' ']' + echo 'A token is mandatory to query the server' + exit 1 parse error: Invalid numeric literal at line 1, column 2 error Rudder agent was interrupted during execution by a fatal error Run with -i to see log messages. ## Summary ##################################################################### 0 components verified in 0 directives execution time: 0.01s ################################################################################
Recommending that the error message echo "A token is mandatory to query the server"
is shown on stderr and that a sanity-check is run before full_api_call
is actually used as input for a pipe, so that a valid pre-execution error message can be displayed to the user instead of guessing what "parse error: Invalid numeric literal at line 1, column 2" actually hides.
ver 4.1.7-2 sles11
Updated by Félix DALLIDET over 6 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Félix DALLIDET to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/rudder-agent/pull/196
Updated by Félix DALLIDET over 6 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder-agent|21175059267f6be3beb2fe027030c806b6151fea.
Updated by Nicolas CHARLES over 6 years ago
I struggled to check that it work. On a centos7 (at least), the proper command to run remote is
rudder remote run -at token
any other combinaison (notably -a -t ) fails on centos7
Updated by Vincent MEMBRÉ over 6 years ago
- Status changed from Pending release to Released