Project

General

Profile

Actions
Copy link

User story #11610

closed

file_copy_with_check

Added by François ARMAND over 6 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Generic methods
Target version:
4.1.10
Pull Request:
https://github.com/Normation/ncf/pull...
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We would like to be able to use a method which copy a file only if the dest file is different and an oracle returns "ok".

The workflow would be the one:

Files

Download all files
copy_file_with_validation.png (7.34 KB) copy_file_with_validation.png François ARMAND, 2017-10-17 14:28
copy_file_with_validation.png (66.7 KB) copy_file_with_validation.png François ARMAND, 2017-10-17 14:31
Actions
Copy link
 #2

Updated by Benoît PECCATTE over 6 years ago

  • Category set to Generic methods
Actions
Copy link
 #3

Updated by Alexis Mousset over 6 years ago

  • Assignee set to Alexis Mousset
  • Target version set to 4.1.10
Actions
Copy link
 #4

Updated by Alexis Mousset over 6 years ago

  • Status changed from New to In progress
Actions
Copy link
 #5

Updated by Alexis Mousset over 6 years ago

  • The actual file copy has to be done by a files promises (to get backup, etc.)
  • The diff check can use a file promise in dry-run mode (or an execresult with the diff command)
Actions
Copy link
 #6

Updated by Alexis Mousset over 6 years ago

It would be called "file_copy_from_local_source_with_check".

Actions
Copy link
 #7

Updated by Alexis Mousset over 6 years ago

  • do we want it to be (possibly ?) recursive?
  • in this case, on what do we call the command?
Actions
Copy link
 #9

Updated by Janos Mattyasovszky about 6 years ago 

bundle agent file_copy_from_local_source_with_check(source, destination, check_command)

You might want to add rc_code_ok or similar, since you might have to have some specific non-zero exit-code that represents a validation success...

Actions
Copy link
 #13

Updated by Alexis Mousset about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/705
Actions
Copy link
 #14

Updated by Alexis Mousset about 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:13e510ced1c300e2af1d9ef8a15b1dd42fb592dd.

Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Actions
Copy link
 #16

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link

Also available in: Atom PDF