Project

General

Profile

Actions
Copy link

Bug #11792

closed

Generic method file_ensure_key_value_present_in_ini_section.cf has leaky classes, resulting in invalid results

Added by Nicolas CHARLES almost 7 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Generic methods
Target version:
4.1.9
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

The order in which the tests are run cause (or not) a success in the test of this method
Plus, it cannot match the end of file for CFEngine 3.7 to 3.9

Subtasks 1 (0 open — 1 closed)

Bug #11802: Broken tests in 4.1+ branch after parent changeReleasedNicolas CHARLESActions

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #11795: Escaping variable in a method call failsReleasedNicolas CHARLESActions
Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 7 years ago

interestingly, with cfengine 3.7, test3 fails, with cfengine 3.10, it's the first one that fails :(

Actions
Copy link
 #2

Updated by Nicolas CHARLES almost 7 years ago

  • Target version changed from 4.3.0~beta1 to 4.1.9

actually, it fails on all version, if only third test is run
there must be an error in the generic method :(

Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 7 years ago

  • Subject changed from Generic method file_ensure_key_value_present_in_ini_section.cf fails on master to Generic method file_ensure_key_value_present_in_ini_section.cf has leaky classes, resulting in invalid results
  • Description updated (diff)
Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 7 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/656
Actions
Copy link
 #6

Updated by Nicolas CHARLES almost 7 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:8161d7a81053194e242135fb3a041b23db11ba61.

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.9 and 4.2.3 which were released today.

Actions
Copy link
 #8

Updated by Vincent MEMBRÉ almost 7 years ago

  • Related to Bug #11795: Escaping variable in a method call fails added
Actions
Copy link
 #9

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link

Also available in: Atom PDF