Project

General

Profile

Actions

Bug #11917

closed

No compliance from a Rule with only one Directive (from a technique created in the editor) when the Directive is also applied in another Rule

Added by Nicolas CHARLES over 3 years ago. Updated over 1 year ago.

Status:
Released
Priority:
N/A
Category:
Web - Compliance & node report
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
0

Description

(i tried my best to have an understandable title...)

Assuming a Technique A, in the Technique Editor, and a Directive D1 based on this Technique, and a Rule R1 with D1 with a large number of node as a target

If we create a Rule R2, with D1 and a sub-set of nodes of R1 as a target, we have the following behaviour:
  1. R2 is shown as "In application"
  2. Compliance is non existent for R2 (spinning wheel)
  3. Compliance by node and directive is empty for R2

We should display more clearly that Directive in R2 is erased, and that this specific Rule is not applied


Subtasks 5 (0 open5 closed)

Bug #16185: "skipped" directive appears even if directive is not skipped in ruleReleasedVincent MEMBRÉActions
Bug #16232: Directive based on a multivalued technique are not marked overridenReleasedNicolas CHARLESActions
Bug #16280: Directives appears both skipped and enforceReleasedNicolas CHARLESActions
Bug #16293: Skipped directives are not displayed anymore - againRejectedFrançois ARMANDActions
Bug #16310: Directive skipped in several place appear duplicatedReleasedNicolas CHARLESActions

Related issues

Related to Rudder - User story #7616: Overriden directives are not listed in reports informationReleasedFrançois ARMANDActions
Actions #1

Updated by Benoît PECCATTE over 3 years ago

  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Priority changed from 0 to 32
Actions #2

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.1.10 to 4.1.11
Actions #3

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 32 to 31
Actions #4

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions #5

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 4.1.13 to 411
Actions #6

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 411 to 4.1.13
Actions #7

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 4.1.13 to 4.1.14
  • Priority changed from 31 to 30
Actions #8

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 4.1.14 to 4.1.15
  • Priority changed from 30 to 29
Actions #9

Updated by François ARMAND over 2 years ago

  • Priority changed from 29 to 28

Hum, that strange, why the directive is not written "overriden" since https://www.rudder-project.org/redmine/issues/7616 ? (I tested again today on 4.3). Missing case when the rule is totally empty?

Actions #10

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions #11

Updated by François ARMAND over 2 years ago

  • Related to User story #7616: Overriden directives are not listed in reports information added
Actions #12

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions #13

Updated by François ARMAND over 2 years ago

  • Effort required set to Very Small
  • Priority changed from 28 to 53

"very small" to at least try to assess the problem.

Actions #14

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.1.17 to 4.1.18
  • Priority changed from 53 to 0
Actions #15

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions #16

Updated by Alexis MOUSSET over 2 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions #17

Updated by François ARMAND about 2 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions #18

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions #19

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 4.1.22 to 4.1.23
Actions #20

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 4.1.23 to 4.1.24
Actions #21

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 4.1.24 to 588
Actions #22

Updated by Benoît PECCATTE almost 2 years ago

  • Target version changed from 588 to 5.0.13
Actions #23

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 5.0.13 to 5.0.14
Actions #24

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 5.0.14 to 5.0.15
Actions #25

Updated by François ARMAND over 1 year ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #26

Updated by François ARMAND over 1 year ago

=> in 5.0.15, we correctly have the overrides value of BoundPolicyDraft set during MergePolicyService#merge.

So the problem is not in that part.

Actions #27

Updated by François ARMAND over 1 year ago

computeExpectedReports has the correct overrides.

But the base don't have the correct rules override ???

Actions #28

Updated by François ARMAND over 1 year ago

OK, the overrides in DB are correct - so it's just a display problem.

Actions #29

Updated by François ARMAND over 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2594
Actions #30

Updated by François ARMAND over 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #33

Updated by Alexis MOUSSET over 1 year ago

  • Subject changed from No compliance from a Rule with only one Directive, based on a Technique made with Technique Editor, when the Directive is also applied in another Rule to No compliance from a Rule with only one Directive (from a technique created in the editor) when the Directive is also applied in another Rule
Actions #34

Updated by François ARMAND over 1 year ago

It seems that the latter changes in that part of the code (either #16185 or the refactoring for performance on rudder/rudder-core/src/main/scala/com/normation/rudder/services/reports/ReportingService.scala broke the correction.

Actions #37

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.15 which was released today.

Actions

Also available in: Atom PDF