Project

General

Profile

Actions

Architecture #11968

closed

Architecture #11955: Remove most scala compilation warning

Remove "N-uple adaptation" warning

Added by François ARMAND over 6 years ago. Updated about 6 years ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Code maintenance
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

Scala is deprecating the use of adaptation from n-args to tuple, so for example you need to use:

val x: Option[(Int, Int)] = Some((1,2))

This is to remove some ambiguities that can lead to non-expected result in some case.

I'm not sure I really like the result. In some caes, the alternative tuple notation works very well, but not always:

... myLiftXmlElement % (("class", "error"))  // bof

... myLiftXmlElement % ("class" -> "error")) // nice!

But in all case, we should have the smallest number of warnings (ideally, 0) with -Xlint option enabled.


Subtasks 1 (0 open1 closed)

Architecture #11975: Remove "N-uple adaptation" warning (missing one)ReleasedVincent MEMBRÉActions
Actions #1

Updated by François ARMAND over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1828
Actions #2

Updated by Rudder Quality Assistant over 6 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions #3

Updated by François ARMAND over 6 years ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.0~beta1 which was released today.

Actions

Also available in: Atom PDF