Bug #12371: Some methods which let another one do the reporting are broken in 4.3 - Rudder - Issue Tracker

Actions

Copy link

Bug #12371

closed

Some methods which let another one do the reporting are broken in 4.3

Added by Alexis Mousset over 6 years ago. Updated over 2 years ago.

Status:

Released

Priority:

N/A

Assignee:

Benoît PECCATTE

Category:

Generic methods

Target version:

4.3.0~rc3

Pull Request:

https://github.com/Normation/ncf/pull...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Because the called method now has disabled reporting. We need to do the reporting in the method itself, and be careful to change the promiser to stay different from the one from the called methods.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Alexis Mousset over 6 years ago

Translation missing: en.field_tag_list set to Blocking 4.3

Actions

Copy link

Updated by Alexis Mousset over 6 years ago

Status changed from New to In progress
Assignee set to Alexis Mousset

Actions

Copy link

Updated by Alexis Mousset over 6 years ago

Status changed from In progress to New
Assignee deleted (~~Alexis Mousset~~)

Broken methods are apparently:

> grep -R -A300 enable_reporting | grep _log | grep -v old_class_prefix | cut -d"-" -f1 | sort
file_copy_from_local_source.cf
file_copy_from_remote_source.cf
file_create_symlink.cf
file_create_symlink_force.cf
file_ensure_lines_present.cf
file_from_local_source.cf
file_from_remote_source.cf
file_from_template_mustache.cf
file_from_template_type.cf
file_lines_present.cf
file_symlink_present.cf
file_symlink_present_force.cf
package_install.cf
package_install_version.cf
package_install_version_cmp.cf
package_verify.cf
package_verify_version.cf
permissions.cf
permissions_dirs.cf
permissions_dirs_recurse.cf
permissions_dirs_recursive.cf
permissions_recurse.cf
permissions_recursive.cf
schedule_simple_catchup.cf
schedule_simple_nodups.cf
schedule_simple_stateless.cf
service_restart.cf
service_restart_if.cf

Actions

Copy link