Project

General

Profile

Actions

Bug #12371

closed

Some methods which let another one do the reporting are broken in 4.3

Added by Alexis Mousset almost 5 years ago. Updated 9 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

Because the called method now has disabled reporting. We need to do the reporting in the method itself, and be careful to change the promiser to stay different from the one from the called methods.


Subtasks 1 (0 open1 closed)

Bug #12421: Missing fixes in parent ticketReleasedBenoît PECCATTEActions
Actions #1

Updated by Alexis Mousset almost 5 years ago

  • translation missing: en.field_tag_list set to Blocking 4.3
Actions #2

Updated by Alexis Mousset almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis Mousset
Actions #3

Updated by Alexis Mousset almost 5 years ago

  • Status changed from In progress to New
  • Assignee deleted (Alexis Mousset)

Broken methods are apparently:

> grep -R -A300 enable_reporting | grep _log | grep -v old_class_prefix | cut -d"-" -f1 | sort
file_copy_from_local_source.cf
file_copy_from_remote_source.cf
file_create_symlink.cf
file_create_symlink_force.cf
file_ensure_lines_present.cf
file_from_local_source.cf
file_from_remote_source.cf
file_from_template_mustache.cf
file_from_template_type.cf
file_lines_present.cf
file_symlink_present.cf
file_symlink_present_force.cf
package_install.cf
package_install_version.cf
package_install_version_cmp.cf
package_verify.cf
package_verify_version.cf
permissions.cf
permissions_dirs.cf
permissions_dirs_recurse.cf
permissions_dirs_recursive.cf
permissions_recurse.cf
permissions_recursive.cf
schedule_simple_catchup.cf
schedule_simple_nodups.cf
schedule_simple_stateless.cf
service_restart.cf
service_restart_if.cf
Actions #4

Updated by Alexis Mousset almost 5 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/724
Actions #5

Updated by Alexis Mousset almost 5 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:4d72335259b64dd4d5e2189fa1ccc2ba7e936475.

Actions #6

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.0~rc3 which was released today.

Actions #7

Updated by Alexis Mousset 9 months ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF