Project

General

Profile

Bug #12371

Some methods which let another one do the reporting are broken in 4.3

Added by Alexis MOUSSET 8 months ago. Updated 8 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
User visibility:
Effort required:
Priority:
0
Tags:

Description

Because the called method now has disabled reporting. We need to do the reporting in the method itself, and be careful to change the promiser to stay different from the one from the called methods.


Subtasks

Bug #12421: Missing fixes in parent ticketReleasedBenoît PECCATTE

Associated revisions

Revision 4d723352 (diff)
Added by Alexis MOUSSET 8 months ago

Fixes #12371: Some methods which let another one do the reporting are broken in 4.3

History

#1 Updated by Alexis MOUSSET 8 months ago

  • Tags set to Blocking 4.3

#2 Updated by Alexis MOUSSET 8 months ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET

#3 Updated by Alexis MOUSSET 8 months ago

  • Status changed from In progress to New
  • Assignee deleted (Alexis MOUSSET)

Broken methods are apparently:

> grep -R -A300 enable_reporting | grep _log | grep -v old_class_prefix | cut -d"-" -f1 | sort
file_copy_from_local_source.cf
file_copy_from_remote_source.cf
file_create_symlink.cf
file_create_symlink_force.cf
file_ensure_lines_present.cf
file_from_local_source.cf
file_from_remote_source.cf
file_from_template_mustache.cf
file_from_template_type.cf
file_lines_present.cf
file_symlink_present.cf
file_symlink_present_force.cf
package_install.cf
package_install_version.cf
package_install_version_cmp.cf
package_verify.cf
package_verify_version.cf
permissions.cf
permissions_dirs.cf
permissions_dirs_recurse.cf
permissions_dirs_recursive.cf
permissions_recurse.cf
permissions_recursive.cf
schedule_simple_catchup.cf
schedule_simple_nodups.cf
schedule_simple_stateless.cf
service_restart.cf
service_restart_if.cf

#4 Updated by Alexis MOUSSET 8 months ago

  • Status changed from New to Pending technical review
  • Assignee set to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/724

#5 Updated by Alexis MOUSSET 8 months ago

  • Status changed from Pending technical review to Pending release

#6 Updated by Vincent MEMBRÉ 8 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.0~rc3 which was released today.

Also available in: Atom PDF