Project

General

Profile

Actions
Copy link

User story #12414

closed

Make reporting work when targeting several time the same item with several generic method

Added by Nicolas CHARLES about 6 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Generic methods
Target version:
4.3.0
Pull Request:
https://github.com/Normation/ncf/pull...
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

For the moment, if we manage twice key->value in the same file, at best we have leakage of reporting from the first GM to the second, at worse the second never reports

For this, I leverage class_prefix, by effectively using it, not having unused definition everywhere
It needs knowledge of the defined classed in the inner method though

Subtasks 3 (0 open — 3 closed)

User story #12441: Avoid duplicating the class clariable in class_prefixReleasedBenoît PECCATTEActions
Bug #12442: Broken reporting for generic method file_ensure_key_value_optionReleasedNicolas CHARLESActions
Bug #12451: In some methods reporting is broken because class_prefix is not correctly updated when using another method ReleasedNicolas CHARLESActions

Related issues 5 (0 open — 5 closed)

Related to Rudder - User story #12426: Use the new class_prefix for service methodsRejectedAlexis MoussetActions
Related to Rudder - Architecture #12427: Use the new class_prefix for package methodsReleasedAlexis MoussetActions
Has duplicate Rudder - Bug #12423: Missing report for Service enabled at boot on RHEL7 for httpdRejectedAlexis MoussetActions
Has duplicate Rudder - Bug #11129: Using of two "File ensure key value in parameter list" methods in the same technique causes the second one to report failed if the first one fails.RejectedActions
Has duplicate Rudder - Bug #10838: File content (Key/value pair) reports for all entries, even if only one changesRejectedActions
Actions
Copy link
 #1

Updated by Nicolas CHARLES about 6 years ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by Nicolas CHARLES about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/734
Actions
Copy link
 #3

Updated by Alexis Mousset about 6 years ago

  • Has duplicate Bug #12423: Missing report for Service enabled at boot on RHEL7 for httpd added
Actions
Copy link
 #4

Updated by Nicolas CHARLES about 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:d41ed781e889d59a68b919b45375d33e7a46519e.

Actions
Copy link
 #5

Updated by Alexis Mousset about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.0 which was released today.

Actions
Copy link
 #6

Updated by Alexis Mousset almost 6 years ago

Actions
Copy link
 #7

Updated by Alexis Mousset almost 6 years ago

Actions
Copy link
 #8

Updated by Nicolas CHARLES almost 6 years ago

  • Has duplicate Bug #11129: Using of two "File ensure key value in parameter list" methods in the same technique causes the second one to report failed if the first one fails. added
Actions
Copy link
 #9

Updated by Nicolas CHARLES almost 6 years ago

  • Has duplicate Bug #10838: File content (Key/value pair) reports for all entries, even if only one changes added
Actions
Copy link
 #10

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link

Also available in: Atom PDF