Actions
Architecture #12636
closedUse pylint to verify python code
Pull Request:
Effort required:
Name check:
Fix check:
Regression:
Description
We have a ton of problems due to python lack of static checks. We have typos (), we have missing imports (#12633), and this has dire consequences in production.
For example, #12633 could have been avoided without any special configuration:
% sudo pacman -S python-pylint ... % pylint --disable=I,R,C,W ncf [18-05-16 11:16:19] No config file found, using default configuration ************* Module ncf E: 62,87: Using variable 'technique' before assignment (used-before-assignment) E: 71,23: Class 'traceback' has no 'format_exc' member (no-member) E: 71,23: Undefined variable 'traceback' (undefined-variable) ------------------------------------------------------------------ Your code has been rated at 7.79/10 (previous run: 7.79/10, +0.00)
We need to force use pylint in any python code before a release. The best place seems to be in CI. The ticket project should be changed if needed, depending on the implemented solution.
Updated by Benoît PECCATTE over 6 years ago
- Status changed from New to In progress
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.12 to 4.1.13
Updated by Benoît PECCATTE over 6 years ago
- Target version changed from 4.1.13 to 411
Updated by Benoît PECCATTE over 6 years ago
- Target version changed from 411 to 4.1.13
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.13 to 4.1.14
Updated by Benoît PECCATTE over 6 years ago
- Target version changed from 4.1.14 to 4.1.15
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.15 to 4.1.16
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.16 to 4.1.17
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.17 to 4.1.18
Updated by Vincent MEMBRÉ almost 6 years ago
- Target version changed from 4.1.18 to 4.1.19
Updated by Alexis Mousset almost 6 years ago
- Target version changed from 4.1.19 to 4.1.20
Updated by François ARMAND almost 6 years ago
- Target version changed from 4.1.20 to 4.1.21
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 4.1.21 to 4.1.22
Updated by Benoît PECCATTE over 5 years ago
- Target version changed from 4.1.22 to 5.0.10
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 5.0.10 to 5.0.11
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 5.0.11 to 5.0.12
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 5.0.12 to 5.0.13
Updated by Benoît PECCATTE over 5 years ago
- Status changed from In progress to Resolved
Done in sub tasks
Actions