Project

General

Profile

Actions
Copy link

Bug #12660

closed

User story #7616: Overriden directives are not listed in reports information

JS error on node compliance details for rule with overiden directives

Added by François ARMAND over 6 years ago. Updated over 6 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Web - Compliance & node report
Target version:
4.1.12
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Priority:
70
Name check:
Fix check:
Regression:

Description

The JS error is:

rudder-datatable.js:1586 Uncaught TypeError: Cannot read property 'val' of undefined
    at compliancePercentValue (rudder-datatable.js:1586)
    at getProgressBars (rudder-datatable.js:1601)
    at buildComplianceBar (rudder-datatable.js:1469)
    at r.fn.init.fnCreatedCell (rudder-datatable.js:764)
    at Ha (datatables.min.js:37)
    at N (datatables.min.js:28)
    at HTMLTableElement.<anonymous> (datatables.min.js:104)
    at Function.each (jquery-3.1.0.min.js:2)
    at r.fn.init.each (jquery-3.1.0.min.js:2)
    at r.fn.init.m [as dataTable] (datatables.min.js:94)
compliancePercentValue @ rudder-datatable.js:1586
getProgressBars @ rudder-datatable.js:1601
buildComplianceBar @ rudder-datatable.js:1469
fnCreatedCell @ rudder-datatable.js:764
Ha @ datatables.min.js:37
N @ datatables.min.js:28
(anonymous) @ datatables.min.js:104
each @ jquery-3.1.0.min.js:2
each @ jquery-3.1.0.min.js:2
m @ datatables.min.js:94
h.fn.DataTable @ datatables.min.js:178
createTable @ rudder-datatable.js:1747
(anonymous) @ rudder-datatable.js:794
(anonymous) @ rudder-datatable.js:1703
dispatch @ jquery-3.1.0.min.js:3
q.handle @ jquery-3.1.0.min.js:3
rudder-datatable.js:1586 Uncaught TypeError: Cannot read property 'val' of undefined
    at compliancePercentValue (rudder-datatable.js:1586)
    at getProgressBars (rudder-datatable.js:1601)
    at buildComplianceBar (rudder-datatable.js:1469)
    at r.fn.init.fnCreatedCell (rudder-datatable.js:764)
    at Ha (datatables.min.js:37)
    at N (datatables.min.js:28)
    at HTMLTableElement.<anonymous> (datatables.min.js:104)
    at Function.each (jquery-3.1.0.min.js:2)
    at r.fn.init.each (jquery-3.1.0.min.js:2)
    at r.fn.init.m [as dataTable] (datatables.min.js:94)
compliancePercentValue @ rudder-datatable.js:1586
getProgressBars @ rudder-datatable.js:1601
buildComplianceBar @ rudder-datatable.js:1469
fnCreatedCell @ rudder-datatable.js:764
Ha @ datatables.min.js:37
N @ datatables.min.js:28
(anonymous) @ datatables.min.js:104
each @ jquery-3.1.0.min.js:2
each @ jquery-3.1.0.min.js:2
m @ datatables.min.js:94
h.fn.DataTable @ datatables.min.js:178
createTable @ rudder-datatable.js:1747
(anonymous) @ rudder-datatable.js:794
(anonymous) @ rudder-datatable.js:1703
dispatch @ jquery-3.1.0.min.js:3
q.handle @ jquery-3.1.0.min.js:3
Actions
Copy link
 #1

Updated by François ARMAND over 6 years ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by François ARMAND over 6 years ago

This does not happen when the node is in "No recent reports" state.

Actions
Copy link
 #3

Updated by François ARMAND over 6 years ago

OK, finally successfully reproduced it on my dev box. It needs some valid compliance for the rule with overriden directive to happen.

Actions
Copy link
 #4

Updated by François ARMAND over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1937
Actions
Copy link
 #5

Updated by François ARMAND over 6 years ago

So, the problem is rudder-datatable.js, where we do a loop on many more elements than an array has. I propose a solution, but it doesn't correct the faulty , it just makes stop the looping when there is no more cells in the array.

Actions
Copy link
 #6

Updated by Rudder Quality Assistant over 6 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #7

Updated by François ARMAND over 6 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.13 to 4.1.12
Actions
Copy link
 #9

Updated by Benoît PECCATTE over 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.12, 4.2.6 and 4.3.1 which were released today.

Actions
Copy link

Also available in: Atom PDF