Project

General

Profile

Actions
Copy link

Bug #12735

closed

Unused formatter in policy generation spend a bit of time in policy generation

Added by Nicolas CHARLES almost 6 years ago. Updated almost 6 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Performance and scalability
Target version:
4.1.13
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

We are still creating AttributeRenderer for specific renderer, that don't exist in techniques since at least Rudder 2.6

So for each template, for each node, we are instancing 3 AttributeRenderer - which add a bit of pression on the GC

Removing them improves the Promises written step generation from 39s to 38s - for 1500 nodes so a minimal improvement, but still an improvement

Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from New to In progress
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/1958
Actions
Copy link
 #4

Updated by Rudder Quality Assistant almost 6 years ago

  • Assignee changed from François ARMAND to Nicolas CHARLES
Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Actions
Copy link

Also available in: Atom PDF