Project

General

Profile

Actions

Architecture #12738

closed

Use elm-install to install elm dependencies instead of just using elm-make

Added by Vincent MEMBRÉ almost 6 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

Some dependencies used in our project (like elm-ui) cannot be installed using elm-make and needs to use elm-install (https://github.com/gdotdesign/elm-github-install).

That command needs to be installed before on ci before being used to create the plugin (done using gem install)

For now i propose to do in build-app.sh elm-install only if elm stuff directory does not exists, or build time will increase a lot during development

I propose to add an option later to force elm-install call

Actions #1

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from New to In progress
Actions #2

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/38
Actions #3

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:rudder-plugins|776970bb91cb0e1eee4e29e4d80e2146af112e65.

Actions #4

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.2 which was released today.

Actions #5

Updated by Vincent MEMBRÉ over 5 years ago

  • Project changed from Rudder to Branding
  • Category deleted (103)
  • Target version changed from 4.3.2 to 4.3-1.0
Actions

Also available in: Atom PDF