Project

General

Profile

Bug #12749

rudder-pkg should fail installation is a dependency is missing

Added by François ARMAND 6 months ago. Updated 5 months ago.

Status:
Released
Priority:
N/A
Category:
Plugins integration
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
61

Description

Today, rudder-pkg install a package even if some of its dependencies are missing, and it prints a warning message.

This is in general not what we want, because nobody seems to read warning and people keep get stuck not knowing why the plugin does not work (for ex after #11115 correction).

Associated revisions

Revision b6d200aa (diff)
Added by Benoît PECCATTE 6 months ago

Fixes #12749: rudder-pkg should fail installation is a dependency is missing

History

#1 Updated by Benoît PECCATTE 6 months ago

This has been done because we have no generic way to install a package from shell.
We could implement this using ncf script, ncf knows how to do this.

#2 Updated by Vincent MEMBRÉ 6 months ago

We already check if the dependency if fullfilled or not, but we only display a warning message and install rpkg and run postint with success which leads to a broken plugin

The idea is to check dependencies before doing anything, and if not present, do not install the rpkg so the user has no problem

The user still has to install dependencies himself

#4 Updated by Benoît PECCATTE 6 months ago

  • Status changed from New to In progress

#5 Updated by Benoît PECCATTE 6 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1605

#6 Updated by Benoît PECCATTE 6 months ago

  • Status changed from Pending technical review to Pending release

#7 Updated by Vincent MEMBRÉ 5 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Also available in: Atom PDF