Bug #12825
closedAdding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable name
Description
Hello Rudder,
I have noticed when I add new parameters in the technique editor to techniques that have existing directives based on it rudder will deploy blank parameters to the systems that that directive influences.
For example i added a parameter group name:
and the following got deployed
${certificate_group}:x:1001:
Then i went to the directive and fixed it by entering a value into the new blank parameter.
I would like to propose the following solutions that might help with this issue:
1. A fallback value (default value) that can be set for all blank fields.
2. Enforcing mandatory values and not allowing deployment until the field is populated in the directive.
Either Or 1 / 2
Thank You : )
Files
Updated by François ARMAND about 6 years ago
- Severity set to Major - prevents use of part of Rudder | no simple workaround
- User visibility set to Operational - other Techniques | Technique editor | Rudder settings
- Priority changed from 0 to 50
Very good propsotion. The long term solution is to correctly manage technique version, so that a directive doesn't have its technique changed without a clear update path. Your two propositions are also to be done (they are all complementary).
I believe we won't be able to make that level of changes in a released version, but it is important. It's linked with the #12824 and fall into "be able to add metadata to technique parameter, like mandatory or not, input type, default value".
Updated by François ARMAND about 6 years ago
- Related to Bug #12824: In directive, change input for parameter from technique editor from text to textarea added
Updated by Benoît PECCATTE about 6 years ago
- Category set to Web - Config management
Updated by François ARMAND about 6 years ago
- Subject changed from Editing Techniques to Adding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable name
- Target version set to 4.3.7
- Effort required set to Very Small
- Priority changed from 50 to 76
Perhaps field should be mandatory in 4.3/5.0 ? In that case, the change is very simple.
Updated by François ARMAND about 6 years ago
- Translation missing: en.field_tag_list set to Sponsored, community
- User visibility changed from Operational - other Techniques | Technique editor | Rudder settings to Operational - other Techniques | Rudder settings | Plugins
- Priority changed from 76 to 107
Updated by Vincent MEMBRÉ about 6 years ago
- Effort required changed from Very Small to Medium
- Priority changed from 107 to 63
Our parameters are already mandatory :(
When we update an already existing technique version, the content of already existing directive is not validated, causing a new generation with empty values in our case.
Some solutions:- Always bump technique version when upgrading a ncf technique. But htere is a cost to migrate all existing technique
- Add checks on techniques when updated then preventing generation
In both cases it's at least a medium operation
Updated by Vincent MEMBRÉ almost 6 years ago
- Target version changed from 4.3.7 to 4.3.8
Updated by Vincent MEMBRÉ almost 6 years ago
- Target version changed from 4.3.8 to 4.3.9
- Priority changed from 63 to 61
Updated by Alexis Mousset almost 6 years ago
- Target version changed from 4.3.9 to 4.3.10
Updated by François ARMAND over 5 years ago
- Target version changed from 4.3.10 to 4.3.11
- Priority changed from 61 to 60
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 4.3.11 to 4.3.12
- Priority changed from 60 to 58
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 4.3.12 to 4.3.13
- Priority changed from 58 to 57
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 4.3.13 to 4.3.14
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 4.3.14 to 587
- Priority changed from 57 to 56
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 587 to 4.3.14
Updated by Alexis Mousset over 5 years ago
- Target version changed from 4.3.14 to 5.0.13
Updated by Vincent MEMBRÉ about 5 years ago
- Target version changed from 5.0.13 to 5.0.14
Updated by Vincent MEMBRÉ about 5 years ago
- Target version changed from 5.0.14 to 5.0.15
Updated by Vincent MEMBRÉ almost 5 years ago
- Target version changed from 5.0.15 to 5.0.16
Updated by Alexis Mousset almost 5 years ago
- Target version changed from 5.0.16 to 5.0.17
Updated by Vincent MEMBRÉ over 4 years ago
- Target version changed from 5.0.17 to 5.0.18
Updated by Vincent MEMBRÉ over 4 years ago
- Target version changed from 5.0.18 to 5.0.19
Updated by Vincent MEMBRÉ about 4 years ago
- Target version changed from 5.0.19 to 5.0.20
Updated by Vincent MEMBRÉ about 4 years ago
- Target version changed from 5.0.20 to 797
Updated by Benoît PECCATTE over 3 years ago
- Target version changed from 797 to 6.1.14
Updated by Vincent MEMBRÉ over 3 years ago
- Target version changed from 6.1.14 to 6.1.15
Updated by Vincent MEMBRÉ over 3 years ago
- Target version changed from 6.1.15 to 6.1.16
- Priority changed from 56 to 57
Updated by Vincent MEMBRÉ about 3 years ago
- Target version changed from 6.1.16 to 6.1.17
Updated by Vincent MEMBRÉ about 3 years ago
- Target version changed from 6.1.17 to 6.1.18
- Priority changed from 57 to 58
Updated by Vincent MEMBRÉ almost 3 years ago
- Target version changed from 6.1.18 to 6.1.19
- Priority changed from 58 to 59
Updated by Vincent MEMBRÉ over 2 years ago
- Target version changed from 6.1.19 to 6.1.20
- Priority changed from 59 to 61
Updated by Vincent MEMBRÉ over 2 years ago
- Target version changed from 6.1.20 to 6.1.21
- Priority changed from 61 to 62
Updated by Vincent MEMBRÉ over 2 years ago
- Target version changed from 6.1.21 to old 6.1 issues to relocate
- Priority changed from 62 to 32
Updated by François ARMAND over 1 year ago
- File clipboard-202303021723-mcc3a.png clipboard-202303021723-mcc3a.png added
- Status changed from New to Resolved
- Priority changed from 32 to 0
- Regression set to No
In Rudder 7.x, this is now resolved: adding a new required parameter leads to generation error