Project

General

Profile

Actions

Bug #12825

closed

Adding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable name

Added by Matthew Frost almost 6 years ago. Updated about 1 year ago.

Status:
Resolved
Priority:
N/A
Category:
Web - Config management
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Medium
Priority:
0
Name check:
Fix check:
Regression:
No

Description

Hello Rudder,

I have noticed when I add new parameters in the technique editor to techniques that have existing directives based on it rudder will deploy blank parameters to the systems that that directive influences.

For example i added a parameter group name:

and the following got deployed

${certificate_group}:x:1001:

Then i went to the directive and fixed it by entering a value into the new blank parameter.

I would like to propose the following solutions that might help with this issue:

1. A fallback value (default value) that can be set for all blank fields.

2. Enforcing mandatory values and not allowing deployment until the field is populated in the directive.

Either Or 1 / 2

Thank You : )


Files

clipboard-202303021723-mcc3a.png (198 KB) clipboard-202303021723-mcc3a.png François ARMAND, 2023-03-02 17:23

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #12824: In directive, change input for parameter from technique editor from text to textarea ReleasedFrançois ARMANDActions
Actions #1

Updated by François ARMAND over 5 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Priority changed from 0 to 50

Very good propsotion. The long term solution is to correctly manage technique version, so that a directive doesn't have its technique changed without a clear update path. Your two propositions are also to be done (they are all complementary).

I believe we won't be able to make that level of changes in a released version, but it is important. It's linked with the #12824 and fall into "be able to add metadata to technique parameter, like mandatory or not, input type, default value".

Actions #2

Updated by François ARMAND over 5 years ago

  • Related to Bug #12824: In directive, change input for parameter from technique editor from text to textarea added
Actions #4

Updated by Benoît PECCATTE over 5 years ago

  • Category set to Web - Config management
Actions #5

Updated by François ARMAND over 5 years ago

  • Subject changed from Editing Techniques to Adding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable name
  • Target version set to 4.3.7
  • Effort required set to Very Small
  • Priority changed from 50 to 76

Perhaps field should be mandatory in 4.3/5.0 ? In that case, the change is very simple.

Actions #6

Updated by François ARMAND over 5 years ago

  • Translation missing: en.field_tag_list set to Sponsored, community
  • User visibility changed from Operational - other Techniques | Technique editor | Rudder settings to Operational - other Techniques | Rudder settings | Plugins
  • Priority changed from 76 to 107
Actions #7

Updated by Vincent MEMBRÉ over 5 years ago

  • Effort required changed from Very Small to Medium
  • Priority changed from 107 to 63

Our parameters are already mandatory :(

When we update an already existing technique version, the content of already existing directive is not validated, causing a new generation with empty values in our case.

Some solutions:
  • Always bump technique version when upgrading a ncf technique. But htere is a cost to migrate all existing technique
  • Add checks on techniques when updated then preventing generation

In both cases it's at least a medium operation

Actions #8

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.3.7 to 4.3.8
Actions #9

Updated by François ARMAND over 5 years ago

  • Assignee set to François ARMAND
Actions #10

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.3.8 to 4.3.9
  • Priority changed from 63 to 61
Actions #11

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 4.3.9 to 4.3.10
Actions #12

Updated by François ARMAND about 5 years ago

  • Target version changed from 4.3.10 to 4.3.11
  • Priority changed from 61 to 60
Actions #13

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.3.11 to 4.3.12
  • Priority changed from 60 to 58
Actions #14

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.3.12 to 4.3.13
  • Priority changed from 58 to 57
Actions #15

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.3.13 to 4.3.14
Actions #16

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 4.3.14 to 587
  • Priority changed from 57 to 56
Actions #17

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 587 to 4.3.14
Actions #18

Updated by Alexis Mousset over 4 years ago

  • Target version changed from 4.3.14 to 5.0.13
Actions #19

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.13 to 5.0.14
Actions #20

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions #21

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.15 to 5.0.16
Actions #22

Updated by Alexis Mousset about 4 years ago

  • Target version changed from 5.0.16 to 5.0.17
Actions #23

Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions #24

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.18 to 5.0.19
Actions #25

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.19 to 5.0.20
Actions #26

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.20 to 797
Actions #27

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 797 to 6.1.14
Actions #28

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.14 to 6.1.15
Actions #29

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.15 to 6.1.16
  • Priority changed from 56 to 57
Actions #30

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.16 to 6.1.17
Actions #31

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.17 to 6.1.18
  • Priority changed from 57 to 58
Actions #32

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.18 to 6.1.19
  • Priority changed from 58 to 59
Actions #33

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.19 to 6.1.20
  • Priority changed from 59 to 61
Actions #34

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.20 to 6.1.21
  • Priority changed from 61 to 62
Actions #36

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.21 to old 6.1 issues to relocate
  • Priority changed from 62 to 32
Actions #37

Updated by François ARMAND about 1 year ago

In Rudder 7.x, this is now resolved: adding a new required parameter leads to generation error

Actions

Also available in: Atom PDF