Project

General

Profile

Actions

Bug #12998

closed

Missing report on File key-value present

Added by Martin Zbozien over 4 years ago. Updated over 4 years ago.

Status:
Released
Priority:
N/A
Category:
System techniques
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

Hi
I have problem with File key-value present.
I need make check on that string:

CONFIG_FILE="/etc/zabbix/zabbix_agentd.conf"

key: CONFIG_FILE
separator: =
value: "/etc/zabbix/zabbix_agentd.conf"

And I'm all time getting

[Missing] [Missing report #0]
[Success] Ensure line in format key=value in /etc/default/zabbix-agent was correct

I'm using 4.3.3 version

Not sure if it is bug or I'm doing something wrong.

Full technique export json below:

{
  "type": "ncf_technique",
  "version": 1,
  "data": {
    "bundle_args": [],
    "bundle_name": "Zabbix_Agent",
    "description": "",
    "name": "Zabbix-Agent Default Proc Conf",
    "version": "1.0",
    "parameter": [],
    "method_calls": [
      {
        "args": [
          "/etc/default/zabbix-agent" 
        ],
        "class_context": "ubuntu",
        "method_name": "file_present",
        "promiser": "method_call" 
      },
      {
        "args": [
          "/etc/default/zabbix-agent",
          "644",
          "root",
          "root" 
        ],
        "class_context": "any",
        "method_name": "permissions" 
      },
      {
        "args": [
          "/etc/default/zabbix-agent",
          "${rudder_parameters.rudder_file_edit_header}" 
        ],
        "class_context": "ubuntu",
        "method_name": "file_block_present",
        "promiser": "method_call" 
      },
      {
        "args": [
          "/etc/default/zabbix-agent",
          "START",
          "\"yes\"",
          "=" 
        ],
        "class_context": "any",
        "method_name": "file_key_value_present" 
      },
      {
        "args": [
          "/etc/default/zabbix-agent",
          "CONFIG_FILE",
          "\"/etc/zabbix/zabbix_agentd.conf\"",
          "=" 
        ],
        "class_context": "any",
        "method_name": "file_key_value_present" 
      },
      {
        "args": [
          "zabbix-agent" 
        ],
        "class_context": "ubuntu.(file_key_value_present__etc_default_zabbix_agent_repaired)",
        "method_name": "command_execution",
        "promiser": "method_call" 
      }
    ]
  }
}

Actions #1

Updated by Nicolas CHARLES over 4 years ago

  • Target version set to 4.3.4

Thank you, you are totally right, this is a bug. Some methods don't have correct reporting when using twice the same component name (for the detail of the issue, the report would be exactly the same, so the agent skips the report)

Actions #2

Updated by Nicolas CHARLES over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #3

Updated by Nicolas CHARLES over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/796
Actions #4

Updated by Nicolas CHARLES over 4 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset ncf:commit:e9811f86eee86503b658d10b58814d6e614cff01.

Actions #5

Updated by Benoît PECCATTE over 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.3.4 which was released today.

Actions

Also available in: Atom PDF