Project

General

Profile

Actions
Copy link

Bug #13204

closed

Bug #13183: Error when using 2 or more File from a jinja2 template

Parent fix breaks ncf tests with old jinja2

Added by Alexis Mousset over 6 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Generic methods
Target version:
4.3.5
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

There is a problem with old jinja2 versions with this change. The newline appended at the end of the second test file is not kept, (in 2.6, contrary to 2.10 for example), leading to different behavior.

The best way to fix it is to make this consistent.M May need to be fixed in 4.1 too.

Actions
Copy link
 #1

Updated by Alexis Mousset over 6 years ago

May be a trim_blocks issue.

Actions
Copy link
 #2

Updated by Alexis Mousset over 6 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis Mousset
Actions
Copy link
 #3

Updated by Félix DALLIDET over 6 years ago

  • Assignee changed from Alexis Mousset to Félix DALLIDET
Actions
Copy link
 #4

Updated by Félix DALLIDET over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/827
Actions
Copy link
 #5

Updated by Félix DALLIDET over 6 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.3.5 and 5.0.1 which were released today. 
Changelog
 Changelog
Actions
Copy link
 #7

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link

Also available in: Atom PDF