Project

General

Profile

Actions

Bug #13204

closed

Bug #13183: Error when using 2 or more File from a jinja2 template

Parent fix breaks ncf tests with old jinja2

Added by Alexis Mousset almost 6 years ago. Updated about 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

There is a problem with old jinja2 versions with this change. The newline appended at the end of the second test file is not kept, (in 2.6, contrary to 2.10 for example), leading to different behavior.

The best way to fix it is to make this consistent.M May need to be fixed in 4.1 too.

Actions #1

Updated by Alexis Mousset almost 6 years ago

May be a trim_blocks issue.

Actions #2

Updated by Alexis Mousset almost 6 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis Mousset
Actions #3

Updated by Félix DALLIDET over 5 years ago

  • Assignee changed from Alexis Mousset to Félix DALLIDET
Actions #4

Updated by Félix DALLIDET over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/827
Actions #5

Updated by Félix DALLIDET over 5 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:ff3d9b36c79629cc2530871c069b8cc976a1a709.

Actions #6

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.3.5 and 5.0.1 which were released today.
Changelog
Changelog
Actions #7

Updated by Alexis Mousset about 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF