Project

General

Profile

Architecture #13396

We need to be able to decide what workflow to use based on the change request

Added by François ARMAND 3 months ago. Updated 3 months ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Internal libs
Target version:
Effort required:

Description

To implement #12194, we need to do modification in Rudder core because we need to be able to decide, given a change request, if that change must be validated with one or another workflow.

This goes above what was firstly imagined of being able to just let the workflow decide what to do (i.e: always use the same workflow, but depending on the change, let it be auto-validated or not), because we need to know early (before workflow start) if the change will need validation or not because we want to inform the user in the validation pop-up (before save).

Most Workflow engines don't work like ours for that exact reason. As steps are not known statically, you can't know what to write before running the workflow. It seems to be a better, more generalized solution, but I don't know how to do that without massive change in Rudder.


Related issues

Related to Change validation - User story #12194: Target groups for the Validation WorkflowPending release

Associated revisions

Revision ac5fe976 (diff)
Added by François ARMAND 3 months ago

Fixes #13396: We need to be able to decide what workflow to use based on the change request

Revision 592c80b8 (diff)
Added by François ARMAND 3 months ago

Fixup! Fixes #13396: We need to be able to decide what workflow to use based on the change request

History

#1 Updated by François ARMAND 3 months ago

#3 Updated by Vincent MEMBRÉ 3 months ago

  • Target version changed from 5.0.0~beta2 to 5.0.0~rc1

#5 Updated by François ARMAND 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2024

#6 Updated by Normation Quality Assistant 3 months ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Vincent MEMBRÉ to François ARMAND

#7 Updated by François ARMAND 3 months ago

  • Status changed from Discussion to Pending release

#9 Updated by Vincent MEMBRÉ 3 months ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 5.0.0~rc1 which was released today.
Changelog

Also available in: Atom PDF