Project

General

Profile

Actions
Copy link

Bug #13634

closed

Generic Method "File copy from remote source" does not report when copying a directory

Added by Félix DALLIDET about 6 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Generic methods
Target version:
4.1.16
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

Somehow, the recursion level of the generic method is hardcoded to 0. Leading to missing reports when dealing with a directory since cfengine can not "produce" any
classes from the 0 level recursion of the directory....

We can change the recursion level to inf to fix this, even if the GM is called "file_from" its description explicitly says "Ensure that a file or directory is copied".

Even with this, we should add a check in the GM to be sure that if no classes are "produced", there will be an error message and not a missing report in the webapp and nothing in the agent logs.

Subtasks 2 (0 open — 2 closed)

Bug #13636: Generic Method "File copy from remote source" does not report when copying a directory (branch 4.3)ReleasedAlexis MoussetActions
Bug #13764: Generic method "File copy from remote source" doesn't copy nor report when copying a folder in Rudder 4.1ReleasedNicolas CHARLESActions
Actions
Copy link
 #1

Updated by Félix DALLIDET about 6 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #2

Updated by Félix DALLIDET about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Alexis Mousset
  • Pull Request set to https://github.com/Normation/ncf/pull/841
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions
Copy link
 #4

Updated by Félix DALLIDET about 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:60594f6bdbee4733963c4c5e8f92e1fefc2ab92b.

Actions
Copy link
 #5

Updated by Nicolas CHARLES about 6 years ago

  • Subject changed from file_from_shared_folder does not report when trying to copy a directory to Generic Method "File copy from remote source" does not report when copying a directory
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.16, 4.3.6 and 5.0.2 which were released today. 
Changelog
 Changelog
 Changelog
Actions
Copy link
 #7

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods - File Management to Generic methods
Actions
Copy link

Also available in: Atom PDF