Actions
Bug #13679
closedOn rudder-webapp upgrade, ncf.conf file is not commited
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Very Small
Priority:
0
Name check:
Fix check:
Regression:
Description
If we update ncf.conf file during upgrade that file is not commited, which may break techniques upgrades
root@server:~# rudder server upgrade-techniques -u error: Your local changes to the following files would be overwritten by checkout: ncf/ncf.conf Please, commit your changes or stash them before you can switch branches. Aborting You have unstagged changes in current branch Aborting
here is the diff after upgrading from 4.1.15 to 4.3.5
root@server:/var/rudder/configuration-repository# git diff diff --git a/ncf/ncf.conf b/ncf/ncf.conf index 813a71d..acae82c 100644 --- a/ncf/ncf.conf +++ b/ncf/ncf.conf @@ -11,7 +11,7 @@ # {{#classes.any}} # Which logger(s) should be used in ncf? (comma separated list) -loggers=_log_default,log_rudder +loggers=log_rudder # Which abort handler(s) should be used in ncf? (comma separated list) abort_handlers=_abort_default,abort_rudder {{/classes.any}}
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.16 to 4.1.17
Updated by Vincent MEMBRÉ about 6 years ago
- Status changed from New to In progress
- Assignee set to Vincent MEMBRÉ
Updated by Vincent MEMBRÉ about 6 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/rudder-packages/pull/1713
Updated by Rudder Quality Assistant about 6 years ago
- Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
Updated by Alexis Mousset about 6 years ago
- Has duplicate User story #6638: ncf.conf should be tracked in the internal git added
Updated by Vincent MEMBRÉ about 6 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder-packages|f270ddbbcd484dbbc60085d57467d806ca453b16.
Updated by Vincent MEMBRÉ almost 6 years ago
- Subject changed from On upgrade ncf.conf file is not commited to On rudder-webapp upgrade, ncf.conf file is not commited
Updated by Vincent MEMBRÉ almost 6 years ago
- Status changed from Pending release to Released
Actions