Project

General

Profile

Actions
Copy link

Bug #13679

closed

On rudder-webapp upgrade, ncf.conf file is not commited

Bug #13679: On rudder-webapp upgrade, ncf.conf file is not commited

Added by Vincent MEMBRÉ about 7 years ago. Updated almost 7 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Packaging
Target version:
4.1.17
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Very Small
Priority:
0
Name check:
Fix check:
Regression:

Description

If we update ncf.conf file during upgrade that file is not commited, which may break techniques upgrades

root@server:~# rudder server upgrade-techniques -u
error: Your local changes to the following files would be overwritten by checkout:
    ncf/ncf.conf
Please, commit your changes or stash them before you can switch branches.
Aborting
You have unstagged changes in current branch
Aborting

here is the diff after upgrading from 4.1.15 to 4.3.5

root@server:/var/rudder/configuration-repository# git diff
diff --git a/ncf/ncf.conf b/ncf/ncf.conf
index 813a71d..acae82c 100644
--- a/ncf/ncf.conf
+++ b/ncf/ncf.conf
@@ -11,7 +11,7 @@
 #
 {{#classes.any}}
 # Which logger(s) should be used in ncf? (comma separated list)
-loggers=_log_default,log_rudder
+loggers=log_rudder
 # Which abort handler(s) should be used in ncf? (comma separated list)
 abort_handlers=_abort_default,abort_rudder
 {{/classes.any}}

Subtasks 1 (0 open — 1 closed)

Bug #13868: Add check of ncf.conf file existence before adding itReleasedAlexis MoussetActions

Related issues 1 (0 open — 1 closed)

Has duplicate Rudder - User story #6638: ncf.conf should be tracked in the internal gitRejectedActions

Updated by Vincent MEMBRÉ about 7 years ago Actions
Copy link
 #1

  • Target version changed from 4.1.16 to 4.1.17

Updated by François ARMAND about 7 years ago Actions
Copy link
 #2

  • Effort required set to Very Small

Updated by Vincent MEMBRÉ almost 7 years ago Actions
Copy link
 #3

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ

Updated by Vincent MEMBRÉ almost 7 years ago Actions
Copy link
 #4

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1713

Updated by Rudder Quality Assistant almost 7 years ago Actions
Copy link
 #5

  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ

Updated by Alexis Mousset almost 7 years ago Actions
Copy link
 #6

  • Has duplicate User story #6638: ncf.conf should be tracked in the internal git added

Updated by Vincent MEMBRÉ almost 7 years ago Actions
Copy link
 #7

  • Status changed from Pending technical review to Pending release

Updated by Vincent MEMBRÉ almost 7 years ago Actions
Copy link
 #8

  • Subject changed from On upgrade ncf.conf file is not commited to On rudder-webapp upgrade, ncf.conf file is not commited

Updated by Vincent MEMBRÉ almost 7 years ago Actions
Copy link
 #9

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.17, 4.3.7 and 5.0.3 which were released today. 
Changelog
 Changelog
 Changelog
Actions
Copy link

Also available in: PDF Atom