Project

General

Profile

Actions

Bug #13679

closed

On rudder-webapp upgrade, ncf.conf file is not commited

Added by Vincent MEMBRÉ over 2 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Severity:
User visibility:
Effort required:
Very Small
Priority:
0

Description

If we update ncf.conf file during upgrade that file is not commited, which may break techniques upgrades

root@server:~# rudder server upgrade-techniques -u
error: Your local changes to the following files would be overwritten by checkout:
    ncf/ncf.conf
Please, commit your changes or stash them before you can switch branches.
Aborting
You have unstagged changes in current branch
Aborting

here is the diff after upgrading from 4.1.15 to 4.3.5

root@server:/var/rudder/configuration-repository# git diff
diff --git a/ncf/ncf.conf b/ncf/ncf.conf
index 813a71d..acae82c 100644
--- a/ncf/ncf.conf
+++ b/ncf/ncf.conf
@@ -11,7 +11,7 @@
 #
 {{#classes.any}}
 # Which logger(s) should be used in ncf? (comma separated list)
-loggers=_log_default,log_rudder
+loggers=log_rudder
 # Which abort handler(s) should be used in ncf? (comma separated list)
 abort_handlers=_abort_default,abort_rudder
 {{/classes.any}}


Subtasks 1 (0 open1 closed)

Bug #13868: Add check of ncf.conf file existence before adding itReleasedAlexis MOUSSETActions

Related issues

Has duplicate Rudder - User story #6638: ncf.conf should be tracked in the internal gitRejectedActions
Actions #1

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions #2

Updated by François ARMAND over 2 years ago

  • Effort required set to Very Small
Actions #3

Updated by Vincent MEMBRÉ over 2 years ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #4

Updated by Vincent MEMBRÉ over 2 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1713
Actions #5

Updated by Rudder Quality Assistant over 2 years ago

  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
Actions #6

Updated by Alexis MOUSSET over 2 years ago

  • Has duplicate User story #6638: ncf.conf should be tracked in the internal git added
Actions #7

Updated by Vincent MEMBRÉ over 2 years ago

  • Status changed from Pending technical review to Pending release
Actions #8

Updated by Vincent MEMBRÉ over 2 years ago

  • Subject changed from On upgrade ncf.conf file is not commited to On rudder-webapp upgrade, ncf.conf file is not commited
Actions #9

Updated by Vincent MEMBRÉ over 2 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.17, 4.3.7 and 5.0.3 which were released today.
Changelog
Changelog
Changelog
Actions

Also available in: Atom PDF