Project

General

Profile

Bug #13679

On rudder-webapp upgrade, ncf.conf file is not commited

Added by Vincent MEMBRÉ about 2 months ago. Updated 17 days ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Severity:
User visibility:
Effort required:
Very Small
Priority:
0

Description

If we update ncf.conf file during upgrade that file is not commited, which may break techniques upgrades

root@server:~# rudder server upgrade-techniques -u
error: Your local changes to the following files would be overwritten by checkout:
    ncf/ncf.conf
Please, commit your changes or stash them before you can switch branches.
Aborting
You have unstagged changes in current branch
Aborting

here is the diff after upgrading from 4.1.15 to 4.3.5

root@server:/var/rudder/configuration-repository# git diff
diff --git a/ncf/ncf.conf b/ncf/ncf.conf
index 813a71d..acae82c 100644
--- a/ncf/ncf.conf
+++ b/ncf/ncf.conf
@@ -11,7 +11,7 @@
 #
 {{#classes.any}}
 # Which logger(s) should be used in ncf? (comma separated list)
-loggers=_log_default,log_rudder
+loggers=log_rudder
 # Which abort handler(s) should be used in ncf? (comma separated list)
 abort_handlers=_abort_default,abort_rudder
 {{/classes.any}}


Subtasks

Bug #13868: Add check of ncf.conf file existence before adding itReleasedAlexis MOUSSET

Related issues

Has duplicate Rudder - User story #6638: ncf.conf should be tracked in the internal gitRejected

Associated revisions

Revision f270ddbb (diff)
Added by Vincent MEMBRÉ about 1 month ago

Fixes #13679: On upgrade ncf.conf file is not commited

History

#1 Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 4.1.16 to 4.1.17

#2 Updated by François ARMAND about 1 month ago

  • Effort required set to Very Small

#3 Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ

#4 Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1713

#5 Updated by Normation Quality Assistant about 1 month ago

  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ

#6 Updated by Alexis MOUSSET 29 days ago

  • Has duplicate User story #6638: ncf.conf should be tracked in the internal git added

#7 Updated by Vincent MEMBRÉ 29 days ago

  • Status changed from Pending technical review to Pending release

#8 Updated by Vincent MEMBRÉ 21 days ago

  • Subject changed from On upgrade ncf.conf file is not commited to On rudder-webapp upgrade, ncf.conf file is not commited

#9 Updated by Vincent MEMBRÉ 17 days ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.17, 4.3.7 and 5.0.3 which were released today.
Changelog
Changelog
Changelog

Also available in: Atom PDF