Enhancement #14488: "Archive everything" in Rudder commits everything in /var/rudder/configuration-repository - Rudder - Issue Tracker

Actions

Copy link

Enhancement #14488

open

"Archive everything" in Rudder commits everything in /var/rudder/configuration-repository

Added by Nicolas CHARLES about 5 years ago. Updated 6 months ago.

Status:

New

Priority:

N/A

Assignee:

François ARMAND

Category:

Web - Maintenance

Target version:

Ideas (not version specific)

Pull Request:

UX impact:

Suggestion strength:

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Very Small

Name check:

Fix check:

Regression:

Description

When we do an archive of Rudder, it first do a commit of /var/rudder/configuration-repository (even for untracked files)
This is really weird and surprising as:

if there are unstaged changes in the Techniques folders, they are commited, and then taken into account in Rudder, so archivin CHANGES the behaviour of Rudder
it causes the Archive to not match what the Rudder server was doing at the time of the Archiving (techniques can be widely different)
it is simply strange to have commits for that

Not that shared-files should probably be added and commited, as they don't need to be in the git tree to be used by nodes (or maybe we should simply include them in the archive, without commit, but it raises the question of the expected behaviour of "restore from latest commit")

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Alexander Brunhirl about 5 years ago

Perhaps there should be a note in the documentation/GUI that if you want to perform a full export, all unstaged files should be commited first. For example, when you transfer/clone the entire rudder environment.

Actions

Copy link

Updated by François ARMAND about 5 years ago

Translation missing: en.field_tag_list set to Sponsored
Severity set to Minor - inconvenience | misleading | easy workaround
User visibility set to Operational - other Techniques | Rudder settings | Plugins
Priority changed from 0 to 65

I think we should error archive if there is uncomited files in `/var/rudder/configuration-repository/techniques` or `/var/rudder/configuration-repository/ncf`. Other directories are OK.
This seems to be the most safe option, as at least it let the user know that what he wanted to do is not what was going to happen - either he forgot to commit some techniques, or he would have archived a bad state.

Actions

Copy link

Updated by Alexander Brunhirl about 5 years ago

François ARMAND wrote:

I think we should error archive if there is uncomited files in `/var/rudder/configuration-repository/techniques` or `/var/rudder/configuration-repository/ncf`. Other directories are OK.
This seems to be the most safe option, as at least it let the user know that what he wanted to do is not what was going to happen - either he forgot to commit some techniques, or he would have archived a bad state.

That would be great, thanks! :)

Actions

Copy link

Updated by François ARMAND about 5 years ago

Assignee set to François ARMAND

Actions

Copy link

Updated by Vincent MEMBRÉ about 5 years ago

Target version changed from 4.1.21 to 4.1.22

Actions

Copy link

Updated by Vincent MEMBRÉ almost 5 years ago

Target version changed from 4.1.22 to 4.1.23
Priority changed from 65 to 64

Actions

Copy link

Updated by Vincent MEMBRÉ almost 5 years ago

Target version changed from 4.1.23 to 4.1.24

Actions

Copy link

Updated by Vincent MEMBRÉ almost 5 years ago

Target version changed from 4.1.24 to 588
Priority changed from 64 to 62

Actions

Copy link

Updated by Nicolas CHARLES almost 5 years ago

Target version changed from 588 to 5.0.13

Actions

Copy link

#10

Updated by Vincent MEMBRÉ over 4 years ago

Target version changed from 5.0.13 to 5.0.14
Priority changed from 62 to 61

Actions

Copy link

#11

Updated by Vincent MEMBRÉ over 4 years ago

Target version changed from 5.0.14 to 5.0.15
Priority changed from 61 to 59

Actions

Copy link

#12

Updated by François ARMAND over 4 years ago

Effort required set to Very Small
Priority changed from 59 to 84

Actions

Copy link

#13

Updated by Vincent MEMBRÉ over 4 years ago

Target version changed from 5.0.15 to 5.0.16
Priority changed from 84 to 83

Actions

Copy link

#14

Updated by Alexis Mousset about 4 years ago

Target version changed from 5.0.16 to 5.0.17
Priority changed from 83 to 79

Actions

Copy link

#15

Updated by Vincent MEMBRÉ about 4 years ago

Target version changed from 5.0.17 to 5.0.18
Priority changed from 79 to 78

Actions

Copy link

#16

Updated by Vincent MEMBRÉ over 3 years ago

Target version changed from 5.0.18 to 5.0.19

Actions

Copy link

#17

Updated by Vincent MEMBRÉ over 3 years ago

Target version changed from 5.0.19 to 5.0.20

Actions

Copy link

#18

Updated by Vincent MEMBRÉ over 3 years ago

Target version changed from 5.0.20 to 797

Actions

Copy link

#19

Updated by Benoît PECCATTE almost 3 years ago

Target version changed from 797 to 6.1.14

Actions

Copy link

#20

Updated by Vincent MEMBRÉ almost 3 years ago

Target version changed from 6.1.14 to 6.1.15

Actions

Copy link

#21

Updated by Vincent MEMBRÉ over 2 years ago

Target version changed from 6.1.15 to 6.1.16

Actions

Copy link

#22

Updated by Vincent MEMBRÉ over 2 years ago

Target version changed from 6.1.16 to 6.1.17

Actions

Copy link

#23

Updated by Vincent MEMBRÉ over 2 years ago

Target version changed from 6.1.17 to 6.1.18

Actions

Copy link

#24

Updated by Vincent MEMBRÉ over 2 years ago

Target version changed from 6.1.18 to 6.1.19

Actions

Copy link

#25

Updated by François ARMAND about 2 years ago

Tracker changed from Bug to Enhancement
Severity deleted (~~Minor - inconvenience | misleading | easy workaround~~)
Priority deleted (78)