Project

General

Profile

Actions
Copy link

Bug #14758

closed

Accepting a change request on dynamic group, make the group empty leads an invalid policy generation

Added by Nicolas CHARLES over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Web - Config management
Target version:
4.1.22
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

When we accept a change request on a dynamic group, the group is empty, and policies are generated, with no node in this groupe (see screenshot)
we need to wait for the next dynamic group refresh to correct it.

solution is to force dynamic group update during first phase of deploy

Files

Capture du 2019-04-24 11-56-32.png (103 KB) Capture du 2019-04-24 11-56-32.png Nicolas CHARLES, 2019-04-24 11:56

Related issues 4 (2 open — 2 closed)

Related to Rudder - Bug #4480: When restoring archive (full or groups) dynamic groups are created emptyReleasedNicolas CHARLESActions
Related to Change validation - Bug #14766: When accepting a change request on a group, it's node list should be computed before savingNewActions
Related to Rudder - Architecture #14767: When we accept nodes, dynamic group should be automatically updated at the end of the acceptation, in a synchronized wayNewActions
Related to Rudder - Bug #14918: Policy generation fails with if update of dynamic groups takes more than 10 seconds ReleasedFrançois ARMANDActions
Actions
Copy link
 #1

Updated by Nicolas CHARLES over 5 years ago

2 options:
  1. extend DynGroupUpdaterService to update all group (this is sync and blocking) - so we know when it's finished. However, if we update all groups during a run of dynamic group update batch, chaos is likely to happen
  2. trigger a dynamic group update batch, and wait for it to be idel
Actions
Copy link
 #2

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #4

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2202
Actions
Copy link
 #5

Updated by Nicolas CHARLES over 5 years ago

pull request fixes the issue, BUT it causes double policy generation (the second not doing anything), as the groups are updated)

Actions
Copy link
 #6

Updated by Nicolas CHARLES over 5 years ago

  • Related to Bug #4480: When restoring archive (full or groups) dynamic groups are created empty added
Actions
Copy link
 #7

Updated by Nicolas CHARLES over 5 years ago

  • Related to Bug #14766: When accepting a change request on a group, it's node list should be computed before saving added
Actions
Copy link
 #8

Updated by Nicolas CHARLES over 5 years ago

  • Related to Architecture #14767: When we accept nodes, dynamic group should be automatically updated at the end of the acceptation, in a synchronized way added
Actions
Copy link
 #9

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from Vincent MEMBRÉ to Nicolas CHARLES
Actions
Copy link
 #10

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 5 years ago

  • Subject changed from when accepting a change request on dynamic group, the group is empty, policy generated are so invalid, and it fixes itself only at next dynamic group refresh to Accepting a change request on dynamic group, make the group empty leads an invalid policy generation
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.22, 4.3.12 and 5.0.10 which were released today.

Actions
Copy link
 #14

Updated by Nicolas CHARLES over 5 years ago

  • Related to Bug #14918: Policy generation fails with if update of dynamic groups takes more than 10 seconds added
Actions
Copy link

Also available in: Atom PDF