Project

General

Profile

Bug #14758

Accepting a change request on dynamic group, make the group empty leads an invalid policy generation

Added by Nicolas CHARLES 7 months ago. Updated 6 months ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

When we accept a change request on a dynamic group, the group is empty, and policies are generated, with no node in this groupe (see screenshot)
we need to wait for the next dynamic group refresh to correct it.

solution is to force dynamic group update during first phase of deploy


Files

Capture du 2019-04-24 11-56-32.png (103 KB) Capture du 2019-04-24 11-56-32.png Nicolas CHARLES, 2019-04-24 11:56

Related issues

Related to Rudder - Bug #4480: When restoring archive (full or groups) dynamic groups are created emptyReleasedActions
Related to Change validation - Bug #14766: When accepting a change request on a group, it's node list should be computed before savingNewActions
Related to Rudder - Architecture #14767: When we accept nodes, dynamic group should be automatically updated at the end of the acceptation, in a synchronized wayNewActions
Related to Rudder - Bug #14918: Policy generation fails with if update of dynamic groups takes more than 10 seconds ReleasedActions

Associated revisions

Revision f60052eb (diff)
Added by Nicolas CHARLES 7 months ago

Fixes #14758: when accepting a change request on dynamic group, the group is empty, policy generated are so invalid, and it fixes itself only at next dynamic group refresh

Revision bdb04f26 (diff)
Added by Nicolas CHARLES 7 months ago

Fixes #14758: when accepting a change request on dynamic group, the group is empty, policy generated are so invalid, and it fixes itself only at next dynamic group refresh

History

#1

Updated by Nicolas CHARLES 7 months ago

2 options:
  1. extend DynGroupUpdaterService to update all group (this is sync and blocking) - so we know when it's finished. However, if we update all groups during a run of dynamic group update batch, chaos is likely to happen
  2. trigger a dynamic group update batch, and wait for it to be idel
#2

Updated by Nicolas CHARLES 7 months ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
#4

Updated by Nicolas CHARLES 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2202
#5

Updated by Nicolas CHARLES 7 months ago

pull request fixes the issue, BUT it causes double policy generation (the second not doing anything), as the groups are updated)

#6

Updated by Nicolas CHARLES 7 months ago

  • Related to Bug #4480: When restoring archive (full or groups) dynamic groups are created empty added
#7

Updated by Nicolas CHARLES 7 months ago

  • Related to Bug #14766: When accepting a change request on a group, it's node list should be computed before saving added
#8

Updated by Nicolas CHARLES 7 months ago

  • Related to Architecture #14767: When we accept nodes, dynamic group should be automatically updated at the end of the acceptation, in a synchronized way added
#9

Updated by Rudder Quality Assistant 7 months ago

  • Assignee changed from Vincent MEMBRÉ to Nicolas CHARLES
#10

Updated by Nicolas CHARLES 7 months ago

  • Status changed from Pending technical review to Pending release
#12

Updated by Vincent MEMBRÉ 6 months ago

  • Subject changed from when accepting a change request on dynamic group, the group is empty, policy generated are so invalid, and it fixes itself only at next dynamic group refresh to Accepting a change request on dynamic group, make the group empty leads an invalid policy generation
#13

Updated by Vincent MEMBRÉ 6 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.22, 4.3.12 and 5.0.10 which were released today.

#14

Updated by Nicolas CHARLES 6 months ago

  • Related to Bug #14918: Policy generation fails with if update of dynamic groups takes more than 10 seconds added

Also available in: Atom PDF