Project

General

Profile

Actions
Copy link

Bug #14770

closed

Invalid comparision of String and Option[String] in HistorizationService

Added by Nicolas CHARLES over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Web - Maintenance
Target version:
4.1.22
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

Compiling Rudder in 4.1 causes

[WARNING] /home/nicolas/dev/4.3/rudder/webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/services/eventlog/HistorizationService.scala:120: warning: Option[String] and String are unrelated: they will most likely always compare unequal
[WARNING]         case Some(entry) => (entry.nodeName != x.hostname || entry.nodeDescription != x.description )
[WARNING]                                                                                    ^
[WARNING] /home/nicolas/dev/4.3/rudder/webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/services/eventlog/HistorizationService.scala:146: warning: Option[String] and String are unrelated: they will most likely always compare unequal
[WARNING]            entry.groupDescription != x.nodeGroup.description ||
[WARNING]                                   ^
[WARNING] /home/nicolas/dev/4.3/rudder/webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/services/eventlog/HistorizationService.scala:181: warning: Option[String] and String are unrelated: they will most likely always compare unequal
[WARNING]            || entry.directiveDescription != directive.shortDescription
[WARNING]                                          ^
[WARNING] /home/nicolas/dev/4.3/rudder/webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/services/eventlog/HistorizationService.scala:185: warning: Option[String] and String are unrelated: they will most likely always compare unequal
[WARNING]            || entry.techniqueDescription != technique.description

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #17778: table nodes contains on entry per node per generation, which is too muchReleasedFrançois ARMANDActions
Actions
Copy link

Also available in: Atom PDF