Project

General

Profile

Actions

Bug #15042

closed

Rule changes SQL request and data structure use too much memory

Added by Nicolas CHARLES over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Category:
Performance and scalability
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Error - Fixed
Regression:

Description

When we update changes, we pass, to a synchronized method, a Seq[ResultRepairedReport], to use only the RuleId and the ExecutinTimeStamp, once cache is init (see NodeChangesService, method update)
On a fairly loaded system, this can cause 28960 reports to be kept in memory for nothing, in different Futures


Subtasks 1 (0 open1 closed)

Bug #15129: Queuing "changes" must be done in 5.1 ReleasedFrançois ARMANDActions
Actions #1

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #2

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/2247
Actions #3

Updated by Rudder Quality Assistant over 5 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from François ARMAND to Nicolas CHARLES
Actions #4

Updated by François ARMAND over 5 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Nicolas CHARLES to François ARMAND

I'm taking over this issue!

Actions #5

Updated by François ARMAND over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request changed from https://github.com/Normation/rudder/pull/2247 to https://github.com/Normation/rudder/pull/2270
Actions #6

Updated by François ARMAND over 5 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Nicolas CHARLES to François ARMAND

I'm taking over this issue!

Actions #7

Updated by François ARMAND over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request changed from https://github.com/Normation/rudder/pull/2270 to https://github.com/Normation/rudder/pull/2281
Actions #8

Updated by Rudder Quality Assistant over 5 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions #9

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from François ARMAND to Nicolas CHARLES
Actions #10

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions #11

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from François ARMAND to Nicolas CHARLES
Actions #12

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions #13

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from François ARMAND to Nicolas CHARLES
Actions #14

Updated by François ARMAND over 5 years ago

  • Status changed from Discussion to Pending technical review
Actions #15

Updated by Rudder Quality Assistant over 5 years ago

  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions #16

Updated by Nicolas CHARLES over 5 years ago

  • Status changed from Pending technical review to Pending release
Actions #17

Updated by Alexis Mousset over 5 years ago

  • Name check set to To do
  • Fix check set to To do
Actions #18

Updated by Alexis Mousset over 5 years ago

  • Name check changed from To do to Needs change
Actions #19

Updated by François ARMAND over 5 years ago

  • Subject changed from Updating changes/repairs (probably) uses too much memory to Changes request and data structure use too much memory
Actions #20

Updated by François ARMAND over 5 years ago

  • Fix check changed from To do to Error - Blocking
Actions #21

Updated by François ARMAND over 5 years ago

  • Subject changed from Changes request and data structure use too much memory to Rule changes SQL request and data structure use too much memory
Actions #22

Updated by François ARMAND over 5 years ago

  • Name check changed from Needs change to To do
Actions #23

Updated by François ARMAND over 5 years ago

  • Fix check changed from Error - Blocking to Error - Fixed
Actions #24

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.12 which was released today.

Actions

Also available in: Atom PDF