Project

General

Profile

Actions
Copy link

Bug #15110

closed

We should test sles and suse classes in ncf tests

Added by Félix DALLIDET almost 5 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Generic methods
Target version:
5.0.12
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

In #13806 we force the definition of the "suse" class when "sles" is defined, but this is only done in the techniques and so, is not patch when doing simple ncf_tests.

Since ncf is no longer designed to be run by itself, we should just change the tests to use "sles" instead of "suse".

Actions
Copy link
 #1

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #2

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from In progress to New
  • Assignee deleted (Félix DALLIDET)
  • Target version changed from 4.1.24 to 5.0.12
Actions
Copy link
 #3

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #4

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/988
Actions
Copy link
 #5

Updated by Félix DALLIDET almost 5 years ago

  • Pull Request deleted (https://github.com/Normation/ncf/pull/988)
Actions
Copy link
 #6

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Nicolas CHARLES to Félix DALLIDET
Actions
Copy link
 #7

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/995
Actions
Copy link
 #8

Updated by Félix DALLIDET almost 5 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:afc3d7df0302bb8fb58ad869e193f4bf986b5bb7.

Actions
Copy link
 #9

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.12 which was released today.

Actions
Copy link
 #10

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link

Also available in: Atom PDF