User story #15155: Add methods to define variables from osquery queries - Rudder - Issue Tracker

Actions

Copy link

User story #15155

closed

Add methods to define variables from osquery queries

Added by Alexis Mousset over 5 years ago. Updated over 2 years ago.

Status:

Released

Priority:

N/A

Assignee:

Alexis Mousset

Category:

Generic methods

Target version:

5.0.13

Pull Request:

https://github.com/Normation/ncf/pull...

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Reviewed

Fix check:

Checked

Regression:

Description

variable_string_from_osquery
variable_dict_from_osquery

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Alexis Mousset over 5 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Alexis Mousset over 5 years ago

Subject changed from Add methods to define variables for osquery queries to Add methods to define variables from osquery queries
Status changed from In progress to New

Actions

Copy link

Updated by Alexis Mousset over 5 years ago

Status changed from New to Pending technical review
Assignee changed from Alexis Mousset to Benoît PECCATTE
Pull Request set to https://github.com/Normation/ncf/pull/997

PR https://github.com/Normation/ncf/pull/997

Actions

Copy link

Updated by Vincent MEMBRÉ over 5 years ago

Target version changed from 5.0.12 to 5.0.13

Actions

Copy link

Updated by Rudder Quality Assistant over 5 years ago

Assignee changed from Benoît PECCATTE to Alexis Mousset

Actions

Copy link

Updated by Alexis Mousset over 5 years ago

Status changed from Pending technical review to Pending release

Applied in changeset 69eb0a9204c08ede43d5027616d71fe78e23d0bf.

Actions

Copy link

Updated by François ARMAND over 5 years ago

Fix check changed from To do to Checked

Test: some caveat that should be documented:

- osquery needs to be installed. It's documented in "setup", but perhaps it could get a bit of emphasis:

This method requires the presence of <a href="https://osquery.io/">osquery</a> on the target nodes.

This method requires the presence of <a href="https://osquery.io/">osquery</a> on the target nodes.
It won't install it automatically. Check the correct way of doing so for your OS.

- you can't use "osquery" variable prefix, which is extremely suprising. If you do so, you get:

   error: Remote bundle variable injection detected!
   error: Variable identifier 'osquery.foo' is not legal
   error: Promise belongs to bundle 'variable_dict_from_osquery' in file '/var/rudder/ncf/common/30_generic_methods/variable_dict_from_osquery.cf' near line 81

I'm opening a ticket for these two enhancements.

Actions

Copy link