Project

General

Profile

Actions
Copy link

Bug #15174

closed

Rudder directives posthook can not support multilines command execution

Added by Félix DALLIDET over 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
5.0.13
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

Posthook can only execute one bash command, but this command should be able to be multiline.
Due to the spacing in the technique file, and how string_template replaces the parameters, the resulting spacing is broken and add unwanted spaces in the posthook when dealing with multiline ones.

We should fix the spacing in all directives using posthooks

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #8933: Multi-line command in post-modification hooks works incorrectlyReleasedNicolas CHARLESActions
Actions
Copy link
 #1

Updated by Félix DALLIDET over 5 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #2

Updated by Félix DALLIDET over 5 years ago

  • Related to Bug #8933: Multi-line command in post-modification hooks works incorrectly added
Actions
Copy link
 #3

Updated by Félix DALLIDET over 5 years ago

Below are the techniques that offers POSTHOOK options:

grep -Rl "HOOK" | grep xml                                                                                                                                   ~> 17:02
fileDistribution/checkGenericFileContent/8.0/metadata.xml
fileDistribution/manageKeyValueFile/1.3/metadata.xml
fileDistribution/fileTemplate/1.0/metadata.xml
fileDistribution/copyGitFile/2.3/metadata.xml
applications/repoGpgKeyManagement/1.1/metadata.xml
applications/packageManagement/1.2/metadata.xml
fileConfiguration/fileManagement/4.1/metadata.xml
systemSettings/remoteAccess/sshKeyDistribution/4.0/metadata.xml
systemSettings/process/services/1.1/metadata.xml
systemSettings/userManagement/sudoParameters/3.2/metadata.xml
systemSettings/systemManagement/cronManagement/3.2/metadata.xml
Actions
Copy link
 #4

Updated by Félix DALLIDET over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1458
Actions
Copy link
 #5

Updated by Félix DALLIDET over 5 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #6

Updated by Nicolas CHARLES about 5 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.13 which was released today.

Actions
Copy link

Also available in: Atom PDF