Project

General

Profile

User story #15184

Improve and correct tests for condition_from_command.cf GM

Added by Félix DALLIDET 4 months ago. Updated 2 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Suggestion strength:
User visibility:
Effort required:

Related issues

Related to ncf - Bug #15189: condition_from_command does not do anything in audit modeReleasedActions

Associated revisions

Revision 7bc6fa73 (diff)
Added by Félix DALLIDET 4 months ago

Fixes #15184: Improve and correct tests for condition_from_command.cf GM

History

#1

Updated by Félix DALLIDET 4 months ago

Surprisingly when writing tests I found out that the command where not executed in audit mode, and so on, the classes never defined.
This is quite a problem to patch since it deeply change the behaviour of the GM.

Still we think we should change the GM to work properly even in audit mode in the next major release of Rudder see #15189.

#2

Updated by Félix DALLIDET 4 months ago

  • Related to Bug #15189: condition_from_command does not do anything in audit mode added
#3

Updated by Félix DALLIDET 4 months ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
#4

Updated by Félix DALLIDET 4 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/1010
#5

Updated by Félix DALLIDET 4 months ago

  • Status changed from Pending technical review to Pending release
#7

Updated by Vincent MEMBRÉ 2 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.13 which was released today.

Also available in: Atom PDF