Project

General

Profile

Actions

Bug #15577

open

Rudder-api-client fails to clean Null parameters before making API calls

Added by Félix DALLIDET over 4 years ago. Updated over 4 years ago.

Status:
Pending release
Priority:
N/A
Category:
Rudder API & CLI
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

When making call to some methods with Null params (the default ones) I got:
File "./rudder-api-client/lib.python/rudder.py", line 254, in create_directive
clean_params(data)
File "./rudder-api-client/lib.python/rudder.py", line 656, in clean_params
for k in data.keys():
RuntimeError: dictionary changed size during iteration

In fact we are iterating over all keys of the dict and removing somes, which is not the proper way.

Actions #1

Updated by Félix DALLIDET over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions #2

Updated by Félix DALLIDET over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-api-client/pull/20
Actions #3

Updated by Félix DALLIDET over 4 years ago

  • Status changed from Pending technical review to Pending release
Actions

Also available in: Atom PDF