Project

General

Profile

Actions
Copy link

Bug #15827

closed

Job to clean unreference software may delete software for pending nodes

Added by Nicolas CHARLES about 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Web - Nodes & inventories
Target version:
5.0.14
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

we store all softwares in ou=Software, which can get pretty big over time
so we created job to purge unreferenced softwares, by looking at nodes in acceptedDit.NODES.dn.getParent - but this search within ou=Accepted inventories, so it missed Pending inventories :(

Actions
Copy link
 #1

Updated by Nicolas CHARLES about 5 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions
Copy link
 #2

Updated by Nicolas CHARLES about 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/2497
Actions
Copy link
 #3

Updated by Nicolas CHARLES about 5 years ago

impact is not very bad, as new inventory will fix data (it didn't break anything on my test platform), but it is quite sad

Actions
Copy link
 #4

Updated by Nicolas CHARLES about 5 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #5

Updated by Alexis Mousset about 5 years ago

  • Name check changed from To do to Reviewed
Actions
Copy link
 #6

Updated by François ARMAND about 5 years ago

  • Fix check changed from To do to Checked

Tested by having a server on debian, a node on centos still in pending (so we are sure soft are not in common).
After one hour, we can see:

[2019-10-09 09:45:34] INFO  scheduledJob - Purged 0 unreferenced softwares

Then we delete the node, and after one more hour we can see:
Purged following software: [very long list of soft]

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.14 which was released today.

Actions
Copy link

Also available in: Atom PDF