Project

General

Profile

Bug #15893

Fix "Non exhaustive pattern match" warning

Added by François ARMAND about 2 months ago. Updated about 1 month ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Refactoring
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

Warning:(120, 28) match may not be exhaustive.
It would fail on the following input: Left((x: Object forSome x not in (bootstrap.liftweb.checks.NcfTechniqueUpgradeError, bootstrap.liftweb.checks.NcfTechniqueUpgradeError.FlagFileError, bootstrap.liftweb.checks.NcfTechniqueUpgradeError.NcfApiAuthFailed)))
        authResponse       <- tryo ( authRequest.asString , "An error occurred while authentication to ncf API", NcfApiAuthFailed)

The problem is with the tryo definition, where catcher is defined on throwable and we only catch NcfApiAuthFailed here.

Associated revisions

Revision 28961b12 (diff)
Added by François ARMAND about 2 months ago

Fixes #15893: Non exhaustive pattern match

History

#1

Updated by François ARMAND about 2 months ago

  • Status changed from New to In progress
#2

Updated by François ARMAND about 2 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2511
#3

Updated by François ARMAND about 2 months ago

  • Status changed from Pending technical review to Pending release
#4

Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 5.0.15 to 5.0.14
#6

Updated by Alexis MOUSSET about 1 month ago

  • Subject changed from Non exhaustive pattern match to Fix "Non exhaustive pattern match" warning
#7

Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.14 which was released today.

Also available in: Atom PDF