Actions
Bug #16135
closedWe can save a technique with empty name when we add a resource
Status:
Released
Priority:
N/A
Assignee:
Category:
Web - Technique editor
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:
Description
On 6.0beta1, I could create a technique with empty name by adding a ressource
the technique was save, without error but could not be seen on directive list, nor be reloaded with error
An Error occured! Could not parse Technique 'technique' Details: caused by : One or more metadata tags not found before the bundle agent declaration (bundle_name, bundle_args) in unknown
Created files were in technique is in /var/rudder/configuration-repository/techniques/ncf_techniques/1.0/
May be unrelated but logs says
2019-11-06 15:53:36.137:WARN:oejs.HttpChannel:qtp1254526270-10: /rudder/secure/api/techniques//1.0/resources org.springframework.security.web.firewall.RequestRejectedException: The request was rejected because the URL was not normalized. at org.springframework.security.web.firewall.StrictHttpFirewall.getFirewalledRequest(StrictHttpFirewall.java:296) at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:194) at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:178) at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:357) at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:270) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:146) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:257) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1595) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1317) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1564) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1219) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144) at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:219) at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:126) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) at org.eclipse.jetty.server.Server.handle(Server.java:531) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:352) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:260) at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:281) at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:102) at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:118) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:333) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:310) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:168) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:126) at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:366) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:762)
Updated by Nicolas CHARLES about 5 years ago
technique is in /var/rudder/configuration-repository/techniques/ncf_techniques/1.0/metadata.xml
It may be because I didn't put a technique name ?
Updated by Nicolas CHARLES about 5 years ago
- Subject changed from Cannot save correctly technique with ressource to We can save a technique with empty name when we add a resource
- Description updated (diff)
Updated by Vincent MEMBRÉ about 5 years ago
- Target version changed from 6.0.0~beta1 to 6.0.0
Updated by Vincent MEMBRÉ about 5 years ago
- Status changed from New to In progress
- Assignee set to Vincent MEMBRÉ
Updated by Vincent MEMBRÉ about 5 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to Raphael GAUTHIER
- Pull Request set to https://github.com/Normation/ncf/pull/1124
Updated by Vincent MEMBRÉ about 5 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset ncf:commit:12b6d8f00aebfd964b3daf36001f7f25e2ca8195.
Updated by Alexis Mousset about 5 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 6.0.0 which was released today.
Updated by François ARMAND over 3 years ago
- Related to Bug #19865: Technique editor allows empty technique name added
Updated by François ARMAND over 3 years ago
- Related to Bug #19930: We were able to save a technique without a name which caused chaos added
Updated by François ARMAND over 3 years ago
We saw new occurence (or variation of that occurence) in 6.2.9. Opening a new ticket for it: #19930
Actions