Project

General

Profile

Bug #16178

Agent is not correctly aborted when repaired is happening in audit mode

Added by Nicolas CHARLES 3 months ago. Updated about 2 months ago.

Status:
Pending release
Priority:
N/A
Category:
System techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:
0

Description

There's a bug in check generic file content, causing it to report repaired when in audit

It doesn't stop the agent

 warning: edit_line warning promised: - kernel.shmmax=i12
 warning: Should edit file '/tmp/audit' but only a warning promised
 warning: Bundle '_abort' should be invoked, but only a warning was promised!
 warning: Method 'rudder_common_report_index' invoked repairs, but only warnings promised

Subtasks

ncf - Bug #16179: Agent is not correctly aborted when dry-run failsPending releaseNicolas CHARLESActions
ncf - Bug #16180: Agent is not correctly aborted when log failsReleasedNicolas CHARLESActions

Related issues

Related to Rudder - Bug #11086: File content directive - Audit mode is not correctly supportedReleasedActions
Related to ncf - Bug #16181: Missing edit_lines promises in dry-run libReleasedActions

Associated revisions

Revision 27a1a155 (diff)
Added by Alexis MOUSSET 3 months ago

Fixes #16178: Agent is not correctly aborted when repaired is happening in audit mode

History

#1

Updated by Nicolas CHARLES 3 months ago

  • Related to Bug #11086: File content directive - Audit mode is not correctly supported added
#2

Updated by Alexis MOUSSET 3 months ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET
#3

Updated by Alexis MOUSSET 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1558
#4

Updated by Alexis MOUSSET 3 months ago

  • Status changed from Pending technical review to Pending release
#5

Updated by Alexis MOUSSET 3 months ago

  • Related to Bug #16181: Missing edit_lines promises in dry-run lib added
#8

Updated by Vincent MEMBRÉ about 2 months ago

This bug has been fixed in Rudder 5.0.15 which was released today.

Also available in: Atom PDF