Project

General

Profile

Actions

Bug #16181

closed

Missing edit_lines promises in dry-run lib

Added by Alexis Mousset over 4 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
To do
Regression:

Description

Currently, we do not define default bodies for edit_lines promises, causing them to ignore dry-run mode.

This can be surprising when using classes define inside an edit_lines bundles while in audit mode.

We should check that adding them does not break anything, and add them.


Related issues 2 (0 open2 closed)

Related to Rudder - Bug #16178: Agent is not correctly aborted when repaired is happening in audit modeReleasedNicolas CHARLESActions
Related to Rudder - Bug #18451: techniques in audit don't report correctly for editing values in filesReleasedAlexis MoussetActions
Actions #1

Updated by Alexis Mousset over 4 years ago

  • Related to Bug #16178: Agent is not correctly aborted when repaired is happening in audit mode added
Actions #2

Updated by Alexis Mousset over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis Mousset
Actions #3

Updated by Alexis Mousset over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/1108
Actions #4

Updated by Alexis Mousset over 4 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:5fe614bcbf79abf5545367ff7a880c583ee7252e.

Actions #5

Updated by Alexis Mousset over 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 6.0.0 which was released today.

Actions #6

Updated by Nicolas CHARLES over 3 years ago

  • Related to Bug #18451: techniques in audit don't report correctly for editing values in files added
Actions #7

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions

Also available in: Atom PDF