Bug #16280: Directives appears both skipped and enforce - Rudder - Issue Tracker

Actions

Bug #16280

closed

Bug #11917: No compliance from a Rule with only one Directive (from a technique created in the editor) when the Directive is also applied in another Rule

Bug #16232: Directive based on a multivalued technique are not marked overriden

Directives appears both skipped and enforce

Added by François ARMAND over 4 years ago. Updated over 4 years ago.

Status:

Released

Priority:

N/A

Assignee:

Nicolas CHARLES

Category:

Web - Compliance & node report

Target version:

5.0.15

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

Major - prevents use of part of Rudder | no simple workaround

UX impact:

User visibility:

Getting started - demo | first install | Technique editor and level 1 Techniques

Effort required:

Very Small

Priority:

Name check:

Reviewed

Fix check:

Error - Fixed

Regression:

Description

Following parent ticket, we now have rules with both skipped and enforce directive, and now I sometimes (not sure why/how) get a variation of #16185.
See screenshot.

Files

Download all files

2019-11-27_15.06.51-Rudder_-_Rules_Management.png (24.1 KB) 2019-11-27_15.06.51-Rudder_-_Rules_Management.png		François ARMAND, 2019-11-27 15:20
2019-11-27_15.06.23-Rudder_-_Rules_Management.png (46 KB) 2019-11-27_15.06.23-Rudder_-_Rules_Management.png		François ARMAND, 2019-11-27 15:20
2019-11-27_15.23.09-Rudder_-_Rules_Management.png (9.92 KB) 2019-11-27_15.23.09-Rudder_-_Rules_Management.png		François ARMAND, 2019-11-27 15:24
2019-11-27_15.22.56-Rudder_-_Rules_Management.png (10.3 KB) 2019-11-27_15.22.56-Rudder_-_Rules_Management.png		François ARMAND, 2019-11-27 15:24

Subtasks 2 (0 open — 2 closed)

Actions

Copy link Download all files

Updated by François ARMAND over 4 years ago

File 2019-11-27_15.23.09-Rudder_-_Rules_Management.png 2019-11-27_15.23.09-Rudder_-_Rules_Management.png added
File 2019-11-27_15.22.56-Rudder_-_Rules_Management.png 2019-11-27_15.22.56-Rudder_-_Rules_Management.png added
Severity set to Major - prevents use of part of Rudder | no simple workaround
User visibility set to Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required set to Very Small
Priority changed from 0 to 98

The problem is that I changed naming convention and the rule with the fewer nodes got first. If it goes second as it was in other case, it's ok (see other screenshots).

So in the case where the rule with fewer nodes is before the one with more node, I think we want to have both rules with "enforce" (and no skipped anywhere).

Actions

Copy link

Updated by François ARMAND over 4 years ago

Status changed from New to In progress

Actions

Copy link

Updated by François ARMAND over 4 years ago

So, the problem is that we have the logic: "if that rule/directive is overriden AND the override is not current rule, print 'skipped'". This logic correct #16185 when the set of nodes with overrides is fully included in the set of node for that rules.

Now we have the case where:

- rule1/dir1 on node 1
- rule2/dir1 on node 1, 2

From rule1:

- dir 1 enforced (because rule1 more prio than rule2)

From rule2:

- dir 1 enforced (because it's on node 2)
- dir 1 skipepd (because it's on node 1 and node1 has rule1/dir1 and rule1 != rule2)

So the logic should be: skipped only directive that are not in the rule in enforce (or audit) at the end.

Actions

Copy link