Actions
Bug #16524
closed
we should not use .size to check if a collection is empty
Status:
Released
Priority:
N/A
Assignee:
Category:
Performance and scalability
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Reviewed
Fix check:
Checked
Regression:
Description
see https://pavelfatin.com/scala-collections-tips-and-tricks/
.size for to iterate over the whole collection/list, so we should use isEmpty or seq.lengthCompare(n)
Updated by Nicolas CHARLES almost 5 years ago
- Status changed from New to In progress
- Assignee set to Nicolas CHARLES
Updated by Nicolas CHARLES almost 5 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/2710
Updated by Nicolas CHARLES almost 5 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|6c5b51b7823f3721a629d830a9b6753526fe9e0e.
Updated by François ARMAND almost 5 years ago
- Fix check changed from To do to Checked
Updated by Alexis Mousset almost 5 years ago
- Name check changed from To do to Reviewed
Updated by Vincent MEMBRÉ almost 5 years ago
This bug has been fixed in Rudder 5.0.16 which was released today.
Updated by Vincent MEMBRÉ almost 5 years ago
- Related to Bug #16537: Node never updated because of nonEmpty in place of isEmpty added
Updated by Vincent MEMBRÉ almost 5 years ago
- Status changed from Pending release to Released
Actions